pointless if() block in EntityViewsData

public function getCustomTableMapping(ContentEntityTypeInterface $entity_type, array $storage_definitions, $prefix = '') { $prefix = $prefix ?: ($this->temporary ? 'tmp_' : ''); return DefaultTableMapping::create($entity_type, $storage_definitions, $prefix); }

Comments & Activities

Issue created by @joachim
First commit to issue fork.
@ranjit1032002 opened merge request.
Status changed to Needs review almost 2 years ago4:23am 23 March 2023
Comment almost 2 years ago →
🇮🇳India Ranjit1032002
Created a MR!3702 for the issue mentioned, please review.
Thank You.
Comment almost 2 years ago →
🇮🇳India anchal_gupta
Fixed CCF
please review it.
Status changed to Needs work almost 2 years ago9:59am 23 March 2023
Comment almost 2 years ago →
🇬🇧United Kingdom joachim
The patch doesn't restore the missing declaration. Also /** @param is incorrect.

Also, please could you stick to using MRs once an issue has MRs? It's confusing to have patches and MRs floating around.
Comment almost 2 years ago →
🇮🇳India Nitin shrivastava
Try to fix CCF error.
Comment almost 2 years ago →
🇬🇧United Kingdom joachim
+++ b/core/modules/views/src/EntityViewsData.php @@ -311,64 +311,63 @@ public function getViewsData() { + $table_mapping = [];
Now you're setting it to an empty array!

That's not right. This needs to keep the definition of that variable.
Comment almost 2 years ago →
RISHABH VISHWAKARMA
Rishabh Vishwakarma → made their first commit to this issue’s fork.
Status changed to RTBC almost 2 years ago9:31am 24 March 2023
Comment almost 2 years ago →
🇬🇧United Kingdom joachim
MR looks good to me.

Test failures appear to be unrelated.
Comment over 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
This is the only instance of if.*getTableMapping in core.

Committed c3f33fa and pushed to 10.1.x. Thanks!
Comment over 1 year ago →
System Message

alexpott → committed c3f33fa6 on 10.1.x
Issue #3349761 by Ranjit1032002, Anchal_gupta, Nitin shrivastava,...
Status changed to Fixed over 1 year ago10:59am 25 April 2023
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

pointless if() block in EntityViewsData

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities