Fix edit-discard-changes and edit-revert buttons hidden bug

Change looks great to me, works like a charm against RC3 -- I'm moving this to RTBC to get the maintainer's attention :-).

We should definitely add @jessehs in credits!

Thanks for creating the branch! Works for me too.

Hi,

Testing gin_lb for the first time.

I confirm the MR fixed the problem.

Thanks!

Hi, I'm a big fan of putting the visibility control into the configuration. Thank you, @grimreaper, for the changes.

Since your changes move visibility handling of the buttons from CSS to field API access, may I suggest creating two setting options, one for each field, instead of combining them?

A use case for the added granularity could be a page editor who wants to discard in-progress layout changes. The site builder/admin wants to limit the possibility of accidental page reversion to its default layout state.

@grimreaper - Here's a patch to your 3349300-fix-edit-discard-changes-and branch that will separate button visibility configurations.

Apologies, wrong file. That patch only contained the updated hook_update change. This is the complete patch against your branch.

Hi,

@pixelcab, Thanks for the new patch. And yes, splitting the two behaviors would be a nice addition.

But I don't understand why you mention me for the changes, it had been done by @Harlor, I only tested it :)

@Grimreaper, ah yes, my confusion. I looked back and just saw the last person to comment. Apologies for the additional notifications, and thank you for testing the original changes and

@harlor, now that I'm speaking to the correct person, do any thoughts starting from comment #9, and if you agree, would the patch changes for your pull request work? Let me know if you'd prefer another method or if there are any changes.

Thanks again, everyone!

@pixelcab, Yes why not - but I think that's worth a new issue.

Btw. As discussed in https://www.drupal.org/project/gin_lb/issues/3336094 📌 edit-discard-changes and edit-revert buttons hidden Fixed the whole configuration should be moved to the theme settings at some point. So maybe one could address this too.

Hi @pixelcab thanks for your work. I will apply your patch until the configuration is moved to the theme config.

Automatically closed - issue fixed for 2 weeks with no activity.

Grimreaper → closed merge request !42