edit-discard-changes and edit-revert buttons hidden

Hi, this is intentional. Maybe we make this configurarble.

Ah ok I tried to introduce such a setting.

Btw. is there a particular reason why the gin_lb settings are not part of the theme settings?

Thanks! And yes the config should be moved to the gin settings.

Automatically closed - issue fixed for 2 weeks with no activity.

There's a typo here that breaks the feature. The setting is hide_discard_revert_button where the .module file checks for hide_discard_revert_buttons (plural).

https://git.drupalcode.org/project/gin_lb/-/blob/1.0.x/gin_lb.module#L347

compare that with

https://git.drupalcode.org/project/gin_lb/-/blob/1.0.x/src/Form/Settings...

It's also missing a line here: https://git.drupalcode.org/project/gin_lb/-/blob/1.0.x/src/Form/Settings...

->set('hide_discard_revert_buttons', $form_state->getValue('hide_discard_revert_buttons'))

I can confirm that the setting Hide "Discard changes" and "Revert to defaults" button on the page /admin/config/gin_lb/settings doesn't work at the moment.
It's supposed to be enabled by default, if I understand correctly. It's always disabled, though.

If I enable the setting and save the form, this setting appears as disabled again. Even if it's disabled, the buttons do not appear in the Layout Builder.

The Discard changes button and the Revert to defaults button do entirely different things and should be treated independently. Therefore, there should be a separate setting for each button.

The possibility to discard changes that may have gone wrong is crucial for every editor.
The possibility to reset the entire page back to defaults, on the other hand, is super dangerous and I always hide it to prevent accidents.

Oops, I've seen the referenced issue that tries to solve the problem just now. 😁