@Grimreaper, ah yes, my confusion. I looked back and just saw the last person to comment. Apologies for the additional notifications, and thank you for testing the original changes and
@harlor, now that I'm speaking to the correct person, do any thoughts starting from comment #9, and if you agree, would the patch changes for your pull request work? Let me know if you'd prefer another method or if there are any changes.
Thanks again, everyone!
Apologies, wrong file. That patch only contained the updated hook_update change. This is the complete patch against your branch.
@grimreaper - Here's a patch to your 3349300-fix-edit-discard-changes-and branch that will separate button visibility configurations.
Hi, I'm a big fan of putting the visibility control into the configuration. Thank you, @grimreaper, for the changes.
Since your changes move visibility handling of the buttons from CSS to field API access, may I suggest creating two setting options, one for each field, instead of combining them?
A use case for the added granularity could be a page editor who wants to discard in-progress layout changes. The site builder/admin wants to limit the possibility of accidental page reversion to its default layout state.