Make assertions using ConfigEntityValidationTestBase::assertValidationErrors() clearer

I like this. Once tests pass I see no real reason not to RTBC it. IMHO it might also make sense for the base class to always assert that property paths are passed as the keys, just so it's not possible to write a test that doesn't include the property paths.

Glad you like it!

IMHO it might also make sense for the base class to always assert that property paths are passed as the keys, just so it's not possible to write a test that doesn't include the property paths.

True, but the assertSame() will make it crystal clear anyway, so I don't see the benefit of making test logic more complicated if it result in almost identical DX :)

Marking it but only question is what if contrib modules are using ConfigEntityValidationTestBase. Will they now fail?

It has only existed in 10.1.x so hasn't shipped in any release at all yet — stable or otherwise! See ✨ Add validation constraints to config_entity.dependencies Fixed :)

I agree with @quietone, we should document what the keys and values mean in the array.

Good call! 😊 Done.

I took advantage of 📌 Update coder to 8.3.18 Fixed having landed a few days ago. That got Drupal core on https://www.drupal.org/project/coder/releases/8.3.18 → , which includes ✨ Support advanced PHPStan data types (general, arrays) Fixed .

That means it's now far easier to clearly convey that key-value pairs are expected, and what the type should be of the keys vs the values.

This documentation looks great!

A low stakes back to NW.

Left two comments on the MR (one on an existing thread) that are simple enough that it would be fine to self-rtbc once addressed.

Great catch, @bnjmnm! 😄

Also, this literally just came up at #3364109-7: Configuration schema & required values: add test coverage for `nullable: true` validation support → !

See the test output at https://www.drupal.org/pift-ci-job/2681594: →

1) Drupal\KernelTests\Core\Entity\EntityFormDisplayValidationTest::testConfigDependenciesValidation with data set "valid dependency types" (array(array('system.site'), array('node:some-random-uuid'), array('system'), array('stark')), array())
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 ()
+Array &0 (
+    0 => 'This value should not be null.'
+)

not very helpful, right? 😳 This fixes that:

1) Drupal\KernelTests\Core\Entity\EntityFormDisplayValidationTest::testConfigDependenciesValidation with data set "valid dependency types" (array(array('system.site'), array('node:some-random-uuid'), array('system'), array('stark')), array())
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 ()
+Array &0 (
+    'status' => 'This value should not be null.'
+)

👍

The failure on 10.1.x is a random fail in Drupal\FunctionalJavascriptTests\Ajax\ThrobberTest.

#14 is green on 11.x 👍

Good stuff here 😎.
Committed to 11.x and cherry-picked to 10.1.x.
🏄‍♀️

bnjmnm → closed merge request !3691

Thank you! 🙏😊

Automatically closed - issue fixed for 2 weeks with no activity.