Contrib.social

Address @todo-comment linking to closed issue in feed-icon.html.twig

Open on Drupal.org →
Created on 14 March 2023, over 2 years ago
Updated 30 April 2023, over 2 years ago

Problem/Motivation

In 📌 [META] Fix @todo items referencing closed issues Active we discovered that there is a @todo in core/themes/olivero/templates/misc/feed-icon.html.twig which references a d.o. issue that is already closed: #3156244: Title variable isn't set by Syndicate block - so the link text is an unfinished sentence → .

Here's the @todo:

{#
  @todo - This works around https://www.drupal.org/project/drupal/issues/3156244,
  Title variable isn't set by Syndicate block.
 #}
{% if title is not defined or title is null %}
  {% set title = 'RSS Feed'|t %}
{% endif %}

Steps to reproduce

Proposed resolution

After #3156244: Title variable isn't set by Syndicate block - so the link text is an unfinished sentence → landed the title of the syndicate block is taken from config: system.site.name.

Which implies to me, that if the title is empty now, it was done on purpose and that an empty title should be honoured.
Which means we should delete the whole Twig code block together with the @todo.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.1 ✨

Component
Olivero  →

Last updated about 2 months ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024