[PP-1] Deprecate the trusted data concept in configuration

Created on 14 March 2023, over 1 year ago
Updated 5 March 2024, 4 months ago

Problem/Motivation

The trusted data concept in the Configuration system is a code smell. It was introduced to improve the situation during site installation where the schema cache is rebuilt time and time again - see #2432791-53: Skip Config::save schema validation of config data for trusted data β†’ but it causes issues like πŸ› Role permissions are not sorted when saving via admin/people/permissions Fixed because it removed sorting in the role entity and adding it to the schema in πŸ› Role permissions not sorted in config export Fixed

If we add sorting to many configuration schemas if we have the trusted data concept we'll need leave code like the code in User::preSave() to sort when it's trusted. That makes the system more fragile than it should be.

Proposed resolution

  • Deprecate the trusted data concept
  • During install make the schema a no-op
  • Add a step once installation of modules and themes is complete to apply schema.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Postponed

Version

11.0 πŸ”₯

Component
ConfigurationΒ  β†’

Last updated about 2 hours ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024