- Issue created by @alexpott
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Trusting data == not validating it, so there's a definite connection to all the config validation work here too π₯Έ
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Ohhh! I've got some good news β¦ while working on another issue ( π Expose API to sort arbitrary config arrays Needs work ), I found blocking bugs (the validation logic for primitives does not match the config schema checking logic).
So I was forced to write test coverage. And I extracted that into a blocking, test-coverage-only issue. While working on that, I made the whole
Config::save(has_trusted_data: TRUE)
thing that this issue aims to deprecate tested separately, to make it easy to extract in the future πPlease review/help land π PrimitiveTypeConstraintValidator vs ConfigSchemaChecker: test coverage to establish the status quo Needs review , it will help reduce the BC break risk for this issue! π
(Thanks @bircher for pointing me to this issue!)
- Status changed to Postponed
9 months ago 4:00pm 5 March 2024 - Merge request !6928Draft: Deprecate the trusted data concept in configuration #3347842 β (Open) created by andypost
- π«π·France andypost
The only question is how to deal with upgrade tests, when we must import old config