Contrib.social

Remove @todo-comment linking to closed issue in layout-builder.css

Open on Drupal.org →
Created on 13 March 2023, over 1 year ago
Updated 28 March 2023, over 1 year ago

Problem/Motivation

As discovered in 📌 [META] Fix @todo items referencing closed issues Active , there is a @todo in core/themes/stable9/css/layout_builder/layout-builder.css which has a link to an issue that is closed as outdated.

Here's the @todo:

/**
 * @todo remove in https://www.drupal.org/project/drupal/issues/3042127
 *   This rule ensures the row weight dropdowns in the Move Block dialog
 *   maintain the background color of their container when they are hovered
 *   over or are inside the active row.
 */
#drupal-off-canvas .layout-builder-components-table__row .form-item {
  background-color: transparent;
}

Steps to reproduce

Proposed resolution

- The current @todo links to 🐛 Off-canvas tabledrag styles do not fully account for "weight" column. Needs work
- That was closed as outdated.
- Since that means there will be no changes related to this CSS-rule, I think removing only the line with the @todo is sufficient here.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Closed: duplicate

Version

10.1 ✨

Component

Stable 9 theme

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024