Remove @todo-comment linking to closed issue in layout-builder.css

Created on 13 March 2023, almost 2 years ago

Updated 28 March 2023, over 1 year ago

Problem/Motivation

As discovered in 📌 [META] Fix @todo items referencing closed issues Active , there is a @todo in core/themes/stable9/css/layout_builder/layout-builder.css which has a link to an issue that is closed as outdated.

Here's the @todo:

/**
 * @todo remove in https://www.drupal.org/project/drupal/issues/3042127
 *   This rule ensures the row weight dropdowns in the Move Block dialog
 *   maintain the background color of their container when they are hovered
 *   over or are inside the active row.
 */
#drupal-off-canvas .layout-builder-components-table__row .form-item {
  background-color: transparent;
}

Steps to reproduce

Proposed resolution

- The current @todo links to 🐛 Off-canvas tabledrag styles do not fully account for "weight" column. Needs work
- That was closed as outdated.
- Since that means there will be no changes related to this CSS-rule, I think removing only the line with the @todo is sufficient here.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Closed: duplicate

Version

10.1 ✨

Component

Stable 9 theme

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Comments & Activities

Issue created by @spokje
@spokje opened merge request.
Status changed to Needs review almost 2 years ago3:30pm 13 March 2023
Comment almost 2 years ago →
🇳🇱Netherlands spokje
Status changed to RTBC almost 2 years ago8:40pm 13 March 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Seems like simple fix.
Status changed to Needs review over 1 year ago8:59am 28 March 2023
Comment over 1 year ago →
🇫🇮Finland lauriii Finland
🐛 Off-canvas tabledrag styles do not fully account for "weight" column. Needs work was closed as outdated potentially because of this workaround 🤔 Maybe we need to keep the todo and reopen the original issue?
Status changed to Closed: duplicate over 1 year ago3:00pm 28 March 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Reopened 🐛 Off-canvas tabledrag styles do not fully account for "weight" column. Needs work

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024