- Issue created by @heddn
- Status changed to Needs review
almost 2 years ago 5:50pm 9 March 2023 - 🇵🇭Philippines paraderojether
@heddn
I applied patch #2 against Views block override version 1.0.x-dev with Drupal Core version 9.5.3, and the patch works fine for me. My only concern is that the "contextual_filter" key should actually be labeled as "Expose contextual filter" instead of "Expose sort", since it's a filter rather than a sort option.
Please check.
Thank You.
- Status changed to Needs work
almost 2 years ago 8:10am 10 March 2023 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
Hi @ , you're right that the label is incorrect. Probably just a copy paste error :)
The schema is referencing to the next code:
if (isset($filtered_allow['contextual_filter'])) { $allowed[] = $this->t('Contextual filters'); }
So I would say the label should be "Contextual filters".
Could you change the MR? - Assigned to indrapatil
- 🇮🇳India indrapatil Bangalore
As per #4, I updated the patch, Please review it
Thank you - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:42pm 10 March 2023 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
Hi @indra-patil, thanks for the rewrite. To help me analyse the correctness of the changed patch, it is advised to provide an interdiff → . Maybe something you can do for the next time. I'll review this and no need to add an interdiff now.
-
tim-diels →
committed 2998a76a on 1.0.x authored by
heddn →
Issue #3347032 by heddn, Indra patil, tim-diels, paraderojether: Missing...
-
tim-diels →
committed 2998a76a on 1.0.x authored by
heddn →
- Status changed to Fixed
almost 2 years ago 1:16pm 10 March 2023 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
Tested and I can confirm it works. Thanks everyone.
Automatically closed - issue fixed for 2 weeks with no activity.