Implement hook_help()

There are a few things wrong with the 2.0.x branch of the issue fork ( https://git.drupalcode.org/issue/responsive_image_preload-3346413/-/comp... ) that will need to be addressed.

  switch ($route_name) {
    case 'help.page.responsive_image_preload':

A switch with a single case should most likely be an if instead.

$output .= '<p>' . t('The Responsive Image Preload module allows you to preload images for responsive images.') . '</p>';

Should probably be more along the lines of "...allows for the automatic generation of preload links for responsive images."

      $output .= '<h4>' . t('Configuration') . '</h4>';
      $output .= '<p>' . t('To use this module, you need to configure the preloading options on the configuration page. This includes enabling the module, selecting the image styles to preload, and choosing whether to preload images only on specific pages or site-wide.') . '</p>';

There is no configuration page. This module simply adds a third party setting to the responsive image field formatter plugin.

      $output .= '<h4>' . t('Usage') . '</h4>';
      $output .= '<p>' . t('Once the module is configured, it will automatically preload the selected image styles on the pages specified in the configuration.') . '</p>';

Shouldn't need a usage section if the verbiage in the first part is updated.

/**
 * Implements hook_menu().
 */
function responsive_image_preload_menu() {
  $items['admin/config/responsive_image_preload'] = array(
    'title' => 'responsive_image_preload Settings',
    'description' => 'Configure the settings for the MyModule responsive_image_preload.',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('responsive_image_preload_settings_form'),
    'access arguments' => array('administer site configuration'),
  );

  // Add a help link to the configuration page.
  $items['admin/config/responsive_image_preload/help'] = array(
    'title' => 'Help',
    'description' => 'Get help for the MyModule module.',
    'access arguments' => array('access content'),
    'type' => MENU_LOCAL_TASK,
    'weight' => 10,
  );

  return $items;
}

This isn't needed at all. There are even still "MyModule" references in this.

I made some changes in .module file and removed the configuration and usage section from it and push code in responsive_image_preload-3346413 (2.0.x) and now it's working fine

nader.mouldi → made their first commit to this issue’s fork.

nader.mouldi → closed merge request !8

I will revise it.

Hi I revised the last MR.

Changes follow the maintainer's desire
Module keeps working as expected

Moving to RTBC

nader.mouldi → closed merge request !11

nader.mouldi → reopened merge request !11

nader.mouldi → closed merge request !11

If you're implementing hook_help it would be better to provide instructions on how to use the module. IMHO it's not really worth it to implement hook_help if the help message doesn't give any further details.

Hi I revised again.

Now the description is detailed.
Im my opinion these changes fixe the issue.

Module is working as expected
MOving to RTBC

Luke.Leber → closed merge request !7

FYI you shouldn't mark a patch/MR you created RTBC, it's considered inappropriate. There are also three merge requests, one issue fork (that needs to be turned into a merge request) and multiple patches, so how is the maintainer supposed to know which one is the "good" one? Lastly, please note that you can modify someone else's merge request, you don't have to create a whole new one if you just want to make some minor improvements to an existing merge request.

" Responsive Image Preload" module not present in D9.5.9