Blocking OR Unblocking users should generate a log entry

Adding a patch to add test for the BlockUser.php file.

Fixed failures in #6.

@ _utsavsharma → Thanks for fixing the issue, though its always better to leave a suggestion for the original contributor to come and fix the issue, specially considering the recent activity on the thread.
As otherwise it appears deliberate attempt to trick the credit system by hijacking the issue by doing trivial changes.

I don't doubt your intent, however we should equally be respectful of others effort and time.

Thanks.

Fully agree with @atul4drupal in #9, adds noise to the ticket.

So believe the tests need to be tweaked, I ran them without the change to the BlockUser.php file and the tests still pass.

Also can we inject the logger.

Thanks for picking this one back up.

Thanks @ smustgrave → for reviewing the patch. I have added updated patch to cover testing the logged message.

Earlier patch missed on this and for this reason it was passing irrespective of any change, hope this will address the scenario.
Do review and suggest.

Thanks.

$this->assertNotNull($log, "No log messages found for channel '$channel' and message '$message'.");

Passes without the fix so may not be needed or needs to be tweaked.

Could we consider extending the scope of this issue by adding the log message on unblock as well? It will be nice to have a log message on block action, but it will be still missing on unblock action. Thanks!

Thinking logging when unblock happens could be in scope too. Would need an issue summary update

Also still think the logger needs to be injected

Added dependency injection, also as per #13 added a log on unblock but need tests

Some minor errors to fix.

Fixed issue and added test coverage for both block user and unblock user action.
Kindly review and suggest.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)