"Accept all cookies" button in fallback overlay translation not working

@bgreco did the patch from #2 solve it for you?

FYI: The translation and configuration fetching is kind of untypical in this module due to the react library used... So we have to check this carefully.
@Grevil could you have a look? Best would be if @JFeltkamp could check it, but he seems lost... :(

@anybody Yes, it fixes the issue for me.

same thing in 2.x

@Grevil: Could you please take a look?

2.x is identical with 1.2.x and will be used for a new Vue frontend in the future.

I couldn't replicate this issue.

Steps I took:

• Fetch current 1.2.x dev and enable the "cookies_video" module
• Translate the "Accept All Message" with "Test" under "/admin/config/system/cookies/texts"
• Check the output on a media field referencing a random youtube video
• Works as expected:

@Grevil: Shouldn't be closed (which is a hard close for all non-maintainers). More than 1 person reported this issue and there's also a patch with a proposed fix.

So we need clearer steps to reproduce and fix this, please. How can we see it's broken and under which conditions @bgreco and @joseph.olstad?

which is a hard close for all non-maintainers

A right I forgot, my apologies.

@Anybody It works in a site's default language, when changing the text at /admin/config/system/cookies/texts like @Grevil did.

It does not work in a site's non-default language, when adding additional translations at /admin/config/system/cookies/texts/translate.

Thanks for the important hint! Back to NW!

Thank you, @bgreco!

I know that your approach works as well, but was unsure if there was a bigger meaning behind using the raw data there. But I couldn't find any. So RTBC from my side.

Works great! Fixed. :)

@Grevil did you compare the resulting contents / array from
getRawData()
vs.
get()?

If it results in different contents within $cookiesTexts that might break other parts below?

I'm happier with get() than with getRawData() but think we can assume there was a reason for that choice perhaps...

I am trying to trace down several "missing translation" issues, namely this one plus issues around the cookie documentation block. In multisite setup with one multilingual site, one site default German and one site default English.

While working on my matrix I was wondering if it made sense to create one issue with an overview. Any hints on how to create a big picture that would be helpful in fixing?

For what it's worth, I just notice that - in contrast to the missing translation - the "Accept all cookies" button in fallback overlay does indeed yield the default config override (original string "Accept All Cookies", changed in default config to lowercased "Accept all cookies".

@Anybody yea I checked this a while ago, seems like I forgot to close this issue.

Automatically closed - issue fixed for 2 weeks with no activity.