- Issue created by @dineshkumarbollu
- 🇮🇳India dineshkumarbollu
Hi
I worked on this issue and created a patch file for this issue please review it. And also attaching screenshot of upgrade status report.
Thanks.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:51am 3 March 2023 - 🇮🇳India dineshkumarbollu
Hi
please review the MR. The patch file as some unwanted changes so i created the MR.
Thanks.
- 🇮🇳India manojapare
I see a lot of unwanted file changes in the above patch file. Attaching a cleaner one.
- 🇮🇳India manojapare
Sorry, previous two patches were not applying properly. Uploading the correct patch file.
- Status changed to RTBC
over 1 year ago 10:23am 28 June 2023 - 🇮🇳India sidharth_soman Bangalore
@manojapare Your patch is failing to apply. Would be useful if I could know which branch you tested it under. I've tried it against 6.0.0, 3345686-D10 and the default dev branch but it doesn't apply on any of the three.
The current MR seems to resolve the compatibility issues. I scanned it and the only error that comes up now is for the core_version_requirement to reflect a Drupal 11 compatibility option... which is obviously not required as this issue is for Drupal 10.
Attached screenshots for reference.
- 🇫🇷France dydave
Hi everyone,
Thanks a lot for the work on this issue, it's greatly appreciated!
Just a quick comment to second the last comment at #9 and confirm merge request MR !3 should be used to fix this issue.
I haven't tested the patches and whether they apply but the one from #8 looks valid as well.
I suppose that's probably up to the maintainer to see how they would like to proceed.
Thanks in advance !
- 🇪🇸Spain jansete
The main page of module: https://www.drupal.org/project/term_name_validation → only show D7 version, mabye could be a barrier that discard community participation, can you create a D10 compatible release at least like alpha / beta / rc? how can we push it?