🇪🇸Spain @jansete

This issue looks very nice, although we have to unify efforts if anybody need a temporary function avoiding conflicts with the final solution of this issue, I've implemented a little module: https://www.drupal.org/project/role_description →

I think that the most useful of having a role description is show this description in the roles checkboxes as description in the user form and be available for others contrib modules like role delegation.

\Drupal\user\AccountForm::form

$form['account']['roles']

The main page of module: https://www.drupal.org/project/term_name_validation → only show D7 version, mabye could be a barrier that discard community participation, can you create a D10 compatible release at least like alpha / beta / rc? how can we push it?

I really don't know how niche feature is, in our case we prefer all statics extensions to process better in differents layers.

4.x's architecture looks very good, congrats! I want to test it soon!

I have the same doubt, maby CDN module is better or core. For instance in core we can set file_public_base_url, for me its something related but maybe it's a feature that it's interesting for CDN module, it's true that sometimes CDN module wasn't enough for some projects and we had to do a custom CDN integration, but I can propose in both projects, related both issues and hope that they with a big picture decide the better choice if they think that this feature is interesting.

Hello cmlara,

Thanks for reviewing!

Reading your review, maybe this feature it should be at core level and not in a specific module like s3f, because It's interesting that works with or without s3fs module.

If you see it, we can decline the issue and I could create a new one in drupal core.

As we know that the speed in core is slower than contrib modules, if in the future somebody or the maintainers decide that the feature is interesting, we can do directly to config entities in 4.x branch and cover with tests.

What do you think?

Greetings.

Added drupal installation prefixes support.

jansete → created an issue.

jansete → created an issue.

I agree with cmlara, working with image styles sometimes could be difficult. If you change a image style the default behaviour is delete all the image styles previously generated and if you use a external service like s3 could be a problem.
You can afford with some tricks, add temporary patches to core to avoid this or use queues to generated in background.
I'm sure that it will be more strategies depends on the problem.

Regards.

Hello! for now we don't notice again, may we can close and re-open or create a new one if this happens again.

Thanks!

Nice improving, reviewed and tested here!

Is exactly that we need, MR looks nice!

MR looks awesome, thanks!

Works for me!

Hello guys,

Sorry I'm not agree with canvas solution, improve content first load but later if you have a big bunch of metatags groups the performance is very poor, on the other hand the async solution only open the metatag group that you need, I think that solution is better and UX/UI as well.

I attach a patch working with nesting robots following #95 solving a php warning when the user doesn't have permission to access metatag fields.

jansete → created an issue. See original summary → .

jansete → created an issue. See original summary → .

jansete → created an issue.

Replace trait to abstract service base to allow override constructor.

jansete → created an issue.

Patch attached.

jansete → created an issue.

I remember that for me I could reproduce with fields that have multiple fields, maybe entity reference with multiple images in the field, because in xdebug y showed an entitties array instead a single entity, for me the last patch worked

I have found a simplier solution.

Only do this:
composer require gravitypdf/querypath

The replace property of gravitypdf composer.json, delete deprecated library and use the new one.

My temporary solution:

Override lullabot/amp repository in composer.json using luigimannoni fork:

"lullabot/amp": {
            "type": "package",
            "package": {
                "name": "lullabot/amp",
                "version": "2.0.4",
                "source": {
                    "type": "git",
                    "url": "https://github.com/deimosindustries/amp-library.git",
                    "reference": "6a3074586ead73cd47cb4fc4e2c429df19fcc2b6"
                }
            }
        }

Reroll patch for the last version.

Hello luigimannoni,

Do you know if we change manually the library, will it works without more changes?

To know until the maintainers fix them.