Place buttons below the comment form, during comment preview

Created on 1 March 2023, over 1 year ago
Updated 2 March 2023, over 1 year ago

Problem/Motivation

In Drupal 7, during comment Preview the "Save" and "Preview" buttons are placed at the very bottom of the page, below the node content being commented on.

Original Issue Summary:
Drupal.org core Change Records pages eg https://www.drupal.org/node/3291493 โ†’
As a logged in user, "Add new Comment" preview UI is broken.

Steps to reproduce

1. Log into Drupal.org into Core Change Record page eg https://www.drupal.org/node/3291493 โ†’
2. Click on "Add a new Comment"
3. Fill some values and in the editor and click "Preview"
4. The new page will show the editor again pre-filled and "Save" and "Preview" buttons are at the bottom of the page
5. Since these buttons are below the fold, a user will get confused if his comment has been submitted or not.

Proposed resolution

During comment Preview, "Save" and "Preview" buttons should be directly below the comment editor box

Currently: Buttons at the bottom

Suggestion: Place the buttons directly below the comment form

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

๐Ÿ“Œ Task
Status

Active

Version

7.0 โšฐ๏ธ

Component
Themeย  โ†’

Last updated about 5 hours ago

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia prabhu9484

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @prabhu9484
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone New Zealand

    Moving to the customization issue queue.

  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen

    Perhaps "Comment settings" under /admin/structure/types/manage/CHANGE_RECORD can be changed from "Required" to "Optional"?

    Or is there a reason why it's not (as in the Forum โ†’ ) possible to select either "Save" or "Preview"?

  • Assigned to drumm
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States drumm NY, US

    There's some question about whether or not change records should even have comments - #1663376: Change records have comments on by default โ†’

    I believe the ordering of the page is how Drupal 7 core behaves. The styling is from the siteโ€™s custom theme. If this really is โ€œbroken,โ€ it's worth checking how a clean install of Drupal works.

    We can make comment previews optional for this content type, so its more likely you know you are clicking โ€œPreviewโ€

    • drumm โ†’ committed 76623e87 on 7.x-3.x
      Issue #3345168 by ressa, drumm: Do not require previewing comments on...
  • Status changed to Fixed over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States drumm NY, US

    Change record comment previews are now optional.

  • Status changed to Active over 1 year ago
  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen

    Thanks @drumm!

    I think I inadvertently hijacked the issue, which is about the buttons being placed at the bottom during preview. I checked in another D7 install, and the behavior was the same -- buttons at the bottom.

    I have a suspicion that this is a new thing ... I think I would have noticed it.

    Could it be, that a recent change in Drupal 7 introduced this? Anyway, this is not a drupalorg, but a general Drupal 7 issue, from what I can tell, so should probably be moved to Drupal core issue queue.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia prabhu9484

    Thanks - So just to be clear on the complete solution here:
    In Drupal 7.x-dev the Comments system should be a 2 step process:
    1. Both "Save" and "Preview" buttons should appear directly below the Editor
    2. If "Saved" the comment should be published below the node
    3. If "Previewed" the comment should appear as preview in a new page, with button options of "Save" and "Discard"

    Please confirm?

  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen

    The process of creating a comment is different, according to the settings under the individual content types, where you can make comment Preview either Required, Disabled or Optional.

    But the real issue here is that the buttons are placed way below at the bottom while previewing, from what I understand?

    Perhaps you can experiment in Drupal 7 with this @prabhu9484, either locally on your own machine, or with https://simplytest.me/?

  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen

    I tried in https://simplytest.me/ and it is a general Drupal 7 issue, so I am updating the Issue Summary.

  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen
  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen
  • Issue was unassigned.
  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States drumm NY, US

    Is the reproducible on Drupal 10? Is it worth fixing in Drupal 7?

  • ๐Ÿ‡ฉ๐Ÿ‡ฐDenmark ressa Copenhagen

    It works as desired in Drupal 10, so all is well there.

    I don't know if it's worth fixing in D7 ... who knows if the planned End-of-Life in November 2023 for Drupal 7 gets extended again? There are after all still +400,000 active Drupal 7 installations โ†’ ...

Production build 0.69.0 2024