- Issue created by @prabhu9484
- Assigned to drumm
- ๐บ๐ธUnited States drumm NY, US
There's some question about whether or not change records should even have comments - #1663376: Change records have comments on by default โ
I believe the ordering of the page is how Drupal 7 core behaves. The styling is from the siteโs custom theme. If this really is โbroken,โ it's worth checking how a clean install of Drupal works.
We can make comment previews optional for this content type, so its more likely you know you are clicking โPreviewโ
- Status changed to Fixed
over 1 year ago 10:18pm 1 March 2023 - ๐บ๐ธUnited States drumm NY, US
Change record comment previews are now optional.
- Status changed to Active
over 1 year ago 10:37pm 1 March 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks @drumm!
I think I inadvertently hijacked the issue, which is about the buttons being placed at the bottom during preview. I checked in another D7 install, and the behavior was the same -- buttons at the bottom.
I have a suspicion that this is a new thing ... I think I would have noticed it.
Could it be, that a recent change in Drupal 7 introduced this? Anyway, this is not a drupalorg, but a general Drupal 7 issue, from what I can tell, so should probably be moved to Drupal core issue queue.
- ๐ฎ๐ณIndia prabhu9484
Thanks - So just to be clear on the complete solution here:
In Drupal 7.x-dev the Comments system should be a 2 step process:
1. Both "Save" and "Preview" buttons should appear directly below the Editor
2. If "Saved" the comment should be published below the node
3. If "Previewed" the comment should appear as preview in a new page, with button options of "Save" and "Discard"Please confirm?
- ๐ฉ๐ฐDenmark ressa Copenhagen
The process of creating a comment is different, according to the settings under the individual content types, where you can make comment Preview either Required, Disabled or Optional.
But the real issue here is that the buttons are placed way below at the bottom while previewing, from what I understand?
Perhaps you can experiment in Drupal 7 with this @prabhu9484, either locally on your own machine, or with https://simplytest.me/?
- ๐ฉ๐ฐDenmark ressa Copenhagen
I tried in https://simplytest.me/ and it is a general Drupal 7 issue, so I am updating the Issue Summary.
- Issue was unassigned.
- ๐บ๐ธUnited States drumm NY, US
Is the reproducible on Drupal 10? Is it worth fixing in Drupal 7?
- ๐ฉ๐ฐDenmark ressa Copenhagen
It works as desired in Drupal 10, so all is well there.
I don't know if it's worth fixing in D7 ... who knows if the planned End-of-Life in November 2023 for Drupal 7 gets extended again? There are after all still +400,000 active Drupal 7 installations โ ...