- Issue created by @Sahana _N
- Status changed to Needs review
almost 2 years ago 9:53am 21 February 2023 - Status changed to RTBC
almost 2 years ago 10:13am 21 February 2023 - First commit to issue fork.
- 🇮🇳India urvashi_vora Madhya Pradesh, India
Reviewed patch provided in #2. Works well and is good for me.
RTBC++
Committing the changes for helping the maintainers.
Thanks for the work.
- Status changed to Needs work
over 1 year ago 5:06am 6 April 2023 - 🇦🇺Australia mstrelan
This does not add any value. Perhaps you can provide instructions on how to use or configure the module? Currently it is just a copy paste of the first sentence on the project page. If I were the maintainer I'd probably mark this "wont fix".
- Assigned to akshaydalvi212
- 🇮🇳India akshaydalvi212
I will provide a better approach for implementing hook_help().
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:22am 6 April 2023 - 🇮🇳India akshaydalvi212
updated the implementation of hook_help() as per requirement in #6.
providing the patch file and interdiff file for reference.
kindly review. - Assigned to himanshu_jhaloya
- Status changed to Needs work
over 1 year ago 12:20pm 6 April 2023 - @himanshu_jhaloya opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:31pm 6 April 2023 - Assigned to akshaydalvi212
- Status changed to Needs work
over 1 year ago 9:54am 7 April 2023 - 🇮🇳India akshaydalvi212
hey @himanshu_jhaloya,
I provided a better approach where we can get the content of the README file
and we can render it using pre tag in patch #8.
I think you have removed the files.
I will update the MR with a similar logic from patch #8.
let the maintainers decide which approach they like to have for the hook_help implementation for the module. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:29am 7 April 2023 - 🇮🇳India akshaydalvi212
made the changes in the implementation of hook_help().
kindly review. - 🇮🇳India Anjali Mehta
Tested the #16 patch on Drupal 9.4.9 and php 8 . It successfully solved the issue.
Can be moved to RTBC. Attaching screenshot for refrenceThanku.
- Status changed to Needs work
over 1 year ago 1:40pm 9 June 2023 Verified the "clamav-3343376-16.patch" on 10.0.0. Hook_help is added but it's redirecting to the website encountered an error and the patch is not cleanly applied.
clamav-3343376-16.patch:36: new blank line at EOF.
+
warning: 1 line adds whitespace errors.- Status changed to Closed: won't fix
9 months ago 6:50pm 24 February 2024