Fix the issues reported by phpcs

FILE: /update_helper/tests/src/Functional/DrushTest.php ---------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------- 112 | ERROR | [x] Expected 1 blank line after function; 2 found ---------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------- FILE: /update_helper/tests/src/Kernel/UpdaterTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 268 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /update_helper/modules/update_helper_checklist/update_helper_checklist.module -------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 7 | WARNING | [x] 'TODO:' should match the format '@todo Fix problem X here.' -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /update_helper/modules/update_helper_checklist/tests/modules/update_helper_checklist_test/update_helper_checklist_test.info.yml -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /update_helper/modules/update_helper_checklist/tests/src/Functional/UpdateHelperChecklistToolbarTest.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 22 | WARNING | [x] A comma should follow the last multiline array item. Found: 'test_page_test' 43 | ERROR | [ ] The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /update_helper/modules/update_helper_checklist/drush.services.yml -------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Expected 1 newline at end of file; 3 found -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: /update_helper/modules/update_helper_checklist/update_helper_checklist.info.yml ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ---------------------------------------------------------------------------------------------------------------- FILE:/update_helper/modules/update_helper_checklist/update_helper_checklist.install ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------- 16 | WARNING | [x] 'TODO: Improve - Get information from executed update hooks, what to mark.' should match the format '@todo Fix problem X here.' 60 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /update_helper/modules/update_helper_checklist/src/UpdateChecklist.php ------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 14 | WARNING | [x] 'TODO: Need tests and a lot!' should match the format '@todo Fix problem X here.' ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: /update_helper/update_helper.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: /update_helper/src/ReversibleConfigDiffer.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 14 | WARNING | [x] 'TODO:' should match the format '@todo Fix problem X here.' 44 | ERROR | [ ] The array declaration extends to column 146 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /update_helper/src/ConfigExporter.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | [x] 'TODO:' should match the format '@todo Fix problem X here.' 58 | WARNING | [x] 'TODO: It would be good to log that file has been changed!!!' should match the format '@todo Fix problem X here.' 73 | ERROR | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /update_helper/src/Generators/ConfigurationUpdate.php -------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------- 113 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 116 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 117 | ERROR | [x] Concat operator must be surrounded by a single space 126 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: /update_helper/src/ConfigHandler.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 15 | WARNING | [x] 'TODO: Create UpdateDefinition class to handle configuration update entry.' should match the format '@todo Fix problem X here.' ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @TanujJain-TJ

Comment almost 2 years ago →

🇮🇳India TanujJain-TJ

Fixed above mentioned phpcs errors in this patch, ignoring .yml file phpcs issues for

 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically

Issue was unassigned.
Status changed to Needs review almost 2 years ago6:16pm 20 February 2023
Comment almost 2 years ago →
🇮🇳India TanujJain-TJ
Comment almost 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work almost 2 years ago7:30am 24 February 2023
Comment almost 2 years ago →
🇮🇳India Akram Khan Cuttack, Odisha
After applying patch #2 still some issue are there. Added SS for reference
Status changed to Needs review almost 2 years ago7:52am 24 February 2023
Comment almost 2 years ago →
🇮🇳India Akram Khan Cuttack, Odisha
Added updated patch it's remove all PHPCS issue now
Comment almost 2 years ago →
System Message
The last submitted patch, 6: 3343217-6.patch, failed testing. View results →
First commit to issue fork.
Assigned to vishaljd
Status changed to Needs work almost 2 years ago4:31am 28 February 2023
Comment almost 2 years ago →
🇮🇳India vishaljd
@vishaljd opened merge request.
Issue was unassigned.
Status changed to Needs review almost 2 years ago8:02am 28 February 2023
Comment almost 2 years ago →
🇮🇳India vishaljd
Comment almost 2 years ago →
🇮🇳India vishaljd
First commit to issue fork.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment over 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
I've enabled gitlabci on 4.0.x let's fix this there and only what is being reported by gitlabci.
@alexpott opened merge request.
Status changed to Fixed over 1 year ago4:14pm 20 September 2023
Comment over 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
The gitlabci pipeline is green!
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities