- Issue created by @dtamajon
- Status changed to Needs work
over 1 year ago 1:20pm 20 February 2023 - 🇫🇮Finland sokru
$route_names array need also following to support translations:
'entity.commerce_product.content_translation_add' 'entity.commerce_product_variation.content_translation_add' - Status changed to Needs review
over 1 year ago 6:49am 24 February 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #2 by addressing #3, please review it.
Thanks!
- 🇺🇸United States paul121 Spokane, WA
This makes me wonder if this wouldn't be desirable for other commerce sites. Your reasoning does make sense to me but I'm just thinking more generally. Could Gin make these gin content forms configurable via a setting in the UI? In addition to allowing other modules to specify this in a hook?
- 🇨🇭Switzerland saschaeggi Zurich
@paul121
Could Gin make these gin content forms configurable via a setting in the UI?
Not in the UI, and we’re not planning in introducing lots of new settings to our UI – but that’s actually already possible via hook_gin_content_form_routes().
- First commit to issue fork.
- @parisek opened merge request.
- Status changed to RTBC
5 months ago 11:18am 6 February 2024 - 🇫🇷France NicolasGraph Strasbourg
The only thing that is kind of weird is the blank sidebar on product variations, but I guess we can't do much here about that. Maybe an issue could be created in commerce to add some more informations there.