- Issue created by @sidharth_soman
- Status changed to Needs work
about 2 years ago 9:10am 16 February 2023 - 🇮🇳India sidharth_soman Bangalore
Finding the following issues. I will work on solving them.
C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig download_all_files-3342296 FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\download_all_files-3342296\css\download_all_files.css ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\download_all_files-3342296\download_all_files.module ---------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 20 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 20 | ERROR | [x] Concat operator must be surrounded by a single space 25 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 26 | ERROR | [x] Case breaking statement indented incorrectly; expected 6 spaces, found 4 ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\download_all_files-3342296\src\Controller\DownloadController.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 19 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\download_all_files-3342296\src\Plugin\Archiver\Zip.php ------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\download_all_files-3342296\src\Plugin\Field\FieldFormatter\DownloadAllFormatter.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- Time: 720ms; Memory: 6MBMoving to 'Needs Work'.
- @sidharth_soman opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 9:19am 16 February 2023 - 🇮🇳India sidharth_soman Bangalore
All errors resolved. Please review the MR created above.
- Status changed to Needs work
about 2 years ago 9:27am 16 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.
- Status changed to RTBC
about 2 years ago 2:16pm 16 February 2023 - 🇮🇳India arunkumark Coimbatore
Reviewed the MR , which applies cleanly and all the coding standard issues got resolved.
Moving to RTBC.
- Status changed to Closed: duplicate
4 months ago 2:03pm 29 November 2024 - 🇧🇪Belgium JeroenT 🇧🇪
All CS are fixed in 📌 Automated Drupal 11 compatibility fixes for download_all_files Needs review .