- Issue created by @sahil.goyal
- Status changed to Needs review
almost 2 years ago 5:30am 15 February 2023 - 🇮🇳India sahil.goyal
Uploading patch to fix all the php coding standard issues and warnings.
Please review.
- Assigned to Charchil Khandelwal
- Issue was unassigned.
- 🇮🇳India Charchil Khandelwal
Patch #2 tested and applied clearly, all the errors and warnings are fixed now.
RTBC +1. - 🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
- 🇮🇳India dev16.addweb
Fixed the below-mentioned errors. and raised Mr for the same.
FILE: /home/addweb/Drupal8-vagrant/web/web/patches/form_mode_control/src/Form/FormModeConfigForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeBundleInfoInterface. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /home/addweb/Drupal8-vagrant/web/web/patches/form_mode_control/src/FormModePermission.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- - 🇵🇭Philippines clarkssquared
Hi
I applied MR !11 and it fixes all the PHPCS issues, I will retaing the status to needs review so that others can give their feedback.
➜ form_mode_control git:(8.x-2.3) ✗ curl https://git.drupalcode.org/project/form_mode_control/-/merge_requests/11.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 15224 0 15224 0 0 21405 0 --:--:-- --:--:-- --:--:-- 21625 patching file form_mode_control.module patching file form_mode_control.routing.yml patching file 'src/Form/FormModeConfigForm.php' patching file 'src/FormModePermission.php' ➜ form_mode_control git:(8.x-2.3) ✗ .. ➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml form_mode_control ➜ contrib git:(master) ✗