Marking notifications read does not work

As @gdeni → pointed out correctly, using the 'uid' key as a replacement still causes an error message in the Watchdog.

(Maybe worth to note that using “notiId” for the same purpose also resolves the problem.)

As it turned out, my guess I wrote in the ticket description still seems to work and does not cause an error message. So I updated my MR with a new commit.

However, storing $notificationData['notiId'] twice in lines #108 and #109 is still not an elegant way. A thorough refactoring is needed definitely.

Using “notiId” resolves the problem for me, but a refactoring is probably needed for the reason mentioned.

Yup, applied patch from #3 commit on 2.0.0-alpha2... problem was resolved.

Still needs a little bit of work based on #4.

Should be easy so tagging as novice. All that needs to happen is to update the MR to remove the variable $notificationId and replace it with $id

I will replace the $notificationId with $id in the MR.

Kindly review the Updated MR.

See comments.

updated the MR.
kindly review.

BramDriesen → closed merge request !11

Automatically closed - issue fixed for 2 weeks with no activity.