Drupal Coding Standards Issues | phpcs

Open on Drupal.org →

Created on 14 February 2023, almost 2 years ago

Updated 13 November 2023, about 1 year ago

Problem/Motivation

Drupal Coding Standards Issues | phpcs

Steps to reproduce

FILE: /taxonomy_delete/taxonomy_delete.drush.inc
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
31 | ERROR | [x] Whitespace found at end of line
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

FILE: /taxonomy_delete/src/Form/TaxonomyDeleteUIForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

FILE: /taxonomy_delete/src/TermDelete.php
---------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace declaration
10 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
12 | ERROR | [x] Whitespace found at end of line
19 | ERROR | [x] Whitespace found at end of line
26 | ERROR | [x] Whitespace found at end of line
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India omkar_yewale Mumbai

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @omkar_yewale
Issue was unassigned.
Status changed to Needs review almost 2 years ago3:55am 14 February 2023
Comment almost 2 years ago →
🇮🇳India omkar_yewale Mumbai
Please Review this Patch.
Comment almost 2 years ago →
🇮🇳India sahil.goyal
sahil.goyal → made their first commit to this issue’s fork.
@sahilgoyal opened merge request.
Status changed to RTBC almost 2 years ago4:10am 14 February 2023
Comment almost 2 years ago →
🇮🇳India sahil.goyal
Applied the #2 resolved all the php coding standard Issues/warnings, creating MR
moving to RTBC, Thanks.
Comment almost 2 years ago →
🇪🇸Spain abelcain Madrid
Dear @sahil.goyal,

I did a review of phpcs and phpmd in the issue https://www.drupal.org/project/taxonomy_delete/issues/3341043 📌 Port to Drupal 10 Needs review

If you agree, we can focus on that review, I can give you contribution to the commits of phpmd and phpcs. Just help me review that ticket and move forward so we have module ported to D10 and with correction of standards.

If it's ok to you, we can close this ticket as duplicated, and you can get the Port to D10 issue to review it.

Kind regards
Abel S.
First commit to issue fork.
@astonvictor opened merge request.
Comment about 1 year ago →
🇺🇦Ukraine AstonVictor
The MR is merged. Fixed all CS issues.
Status changed to Fixed about 1 year ago12:17pm 13 November 2023
Comment about 1 year ago →
System Message
AstonVictor → closed merge request !4
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024