- Issue created by @abelcain
- 🇪🇸Spain abelcain Madrid
Steps to check D10 compatibility
Follow steps:
- Install upgrade status with: "composer require 'drupal/upgrade_status:^4.0@alpha'"
- Enable module with: "./vendor/bin/drush en upgrade_status"
- Perform analysis with: "./vendor/bin/drush upgrade_status:analyze taxonomy_delete"
Compatibility analysis
The results of the analysis
FILE: web/modules/contrib/taxonomy_delete/src/Form/TaxonomyDeleteUIForm.php STATUS LINE MESSAGE -------------------------------------------------------------------------------- Fix now 27 Call to deprecated function taxonomy_vocabulary_get_names(). Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use Drupal::entityQuery('taxonomy_vocabulary')->execute() instead. -------------------------------------------------------------------------------- FILE: web/modules/contrib/taxonomy_delete/taxonomy_delete.info.yml STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687. --------------------------------------------------------------------------------
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 3:54pm 15 February 2023 - 🇪🇸Spain abelcain Madrid
Please, review the code and check it in several drupal versions to see if all works ok, many thanks in advance.
- Assigned to omkar_yewale
- Issue was unassigned.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The patch is correct, but the MR not, since
core: 8.x
cannot be used togethercore_version_requirement: ^8.8 || ^9 || ^10
. - Status changed to RTBC
about 1 year ago 12:05pm 9 October 2023 - 🇳🇱Netherlands Krilo_89
Combined everything into one patch, because now no one can use it. We tested the patch internally and therefore the status is set to RTBC.
Suggestion to maintainer is to remove the old redundant patches in the root of the project, because they are already applied. If you need a second maintainer to help you, please let us know.
- First commit to issue fork.
- @astonvictor opened merge request.
- Status changed to Needs review
about 1 year ago 8:27am 13 November 2023 - 🇺🇦Ukraine AstonVictor
Created a new MR.
It's incorrect to show
ucfirst(str_replace("_", " ", $item->id()));
as a vocabulary label because it does not always match the label.Also, I ran dupal check and found a few errors:
Line taxonomy_delete.drush.inc ------ --------------------------------------------------------------------- 28 Function drush_set_error not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 32 Function drush_confirm not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 41 Function drush_print not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 44 Function drush_user_abort not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
It will be fixed in the issue - https://www.drupal.org/project/taxonomy_delete/issues/3399439 📌 Update drush command Active
- Status changed to Fixed
about 1 year ago 11:36am 13 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.