Update core_version_requirement in .info file.

Created on 9 February 2023, over 1 year ago
Updated 29 July 2023, 11 months ago

Problem/Motivation

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

Steps to reproduce

Try installing in D8 versions < 8.8

Proposed resolution

we should restrict the version by replacing core_version_requirement: ^8.8 || ^9 || ^10

https://www.drupal.org/docs/develop/creating-modules/let-drupal-know-abo... โ†’

๐Ÿ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia Jay Jangid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Jay Jangid
  • @jay-jangid opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Jay Jangid

    Created MR , please review.

    Thank you.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    Yes, I hope this change fixes an issue where for some reason when I do composer require it tries to downgrade Drupal core?

    composer require drupal/content_reminders
    Using version 1.0.x-dev for drupal/content_reminders
    ./composer.json has been updated
    Running composer update drupal/content_reminders
    Gathering patches from patch file.
    Loading composer repositories with package information
    Updating dependencies
    Your requirements could not be resolved to an installable set of packages.
    
      Problem 1
        - drupal/content_reminders dev-1.0.x requires drupal/core ~8.0 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev] but the package is fixed to 9.5.3 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
        - drupal/content_reminders 1.0.x-dev is an alias of drupal/content_reminders dev-1.0.x and thus requires it to be installed too.
        - Root composer.json requires drupal/content_reminders 1.0.x-dev -> satisfiable by drupal/content_reminders[1.0.x-dev (alias of dev-1.0.x)].
    

    but the package is fixed to 9.5.3 (lock file version) by a partial update and that version does not match.
    ?????? Drupal 9.5.3 should work, I prefer 9 over 8, very strange since this project has recent code as of 3 or 4 weeks ago

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    I still get this error with composer require:

    requires drupal/core ~8.0 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev] but the fixed to 9.5.3

    I should be able to install this module with Drupal 9.5.3 however composer is shooting vinaigre on the party.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    Perhaps a tagged release would fix this problem, such as 1.0.0-beta1 ?

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    Until this is fixed, I've cloned and forked this project in my own project and changed composer to use a local path instead of drupal

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States mkinnune

    I've tried doing a tagged release, but it doesn't seem to have helped. I'd be okay with completely dropping support of drupal 8 with this module and changing the core version requirement to instead just include 9 and 10: core_version_requirement: ^9 || ^10

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States netboss New Smyrna Beach, FL
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    yes please drop D8 support, this should fix the issue.

  • First commit to issue fork.
  • @elber opened merge request.
  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil elber Brazil

    Hi I updated the info file please revise.

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น

    +core: 8.x
    core_version_requirement: ^8.8 || ^9

    core cannot be used with the value used for core_version_requirement.

  • ๐Ÿ‡ง๐Ÿ‡ทBrazil elber Brazil

    based in the comments #10 and #11 Does drupal8 support will be dropped?

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    @apadermo has the right idea
    this line:
    core: 8.x
    is deprecated

    This line should be ok:
    core_version_requirement: ^8.8 || ^9 || ^10

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    I just tried this:

    composer require 'drupal/content_reminders:1.0.x-dev@dev'

    same error,

    maybe try removing ^8.8 ||
    instead should probably consider adding || ^10

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil elber Brazil

    Please revise.

  • ๐Ÿ‡ช๐Ÿ‡ธSpain alvar0hurtad0 Cรกceres

    Please consider don't provide credits in case of minor contributions (like this comment I'm doing right now)

  • Status changed to Fixed over 1 year ago
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil elber Brazil

    Hi moving to Fixed because the changes have already been commited

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 11 months ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada joseph.olstad

    FYI, I added another tagged release with this commit:

    https://git.drupalcode.org/project/content_reminders/-/commit/3795c8633f...

    now this module should finally be ready for D10.

    Our private packagist has a delay takes longer to pick up new releases from Drupals packagist so I'll confirm the tagged release is good asap but have to wait a bit.

Production build 0.69.0 2024