- Issue created by @jay jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 4:55am 9 February 2023 - ๐จ๐ฆCanada joseph.olstad
Yes, I hope this change fixes an issue where for some reason when I do composer require it tries to downgrade Drupal core?
composer require drupal/content_reminders Using version 1.0.x-dev for drupal/content_reminders ./composer.json has been updated Running composer update drupal/content_reminders Gathering patches from patch file. Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages. Problem 1 - drupal/content_reminders dev-1.0.x requires drupal/core ~8.0 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev] but the package is fixed to 9.5.3 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command. - drupal/content_reminders 1.0.x-dev is an alias of drupal/content_reminders dev-1.0.x and thus requires it to be installed too. - Root composer.json requires drupal/content_reminders 1.0.x-dev -> satisfiable by drupal/content_reminders[1.0.x-dev (alias of dev-1.0.x)].
but the package is fixed to 9.5.3 (lock file version) by a partial update and that version does not match.
?????? Drupal 9.5.3 should work, I prefer 9 over 8, very strange since this project has recent code as of 3 or 4 weeks ago -
netboss โ
committed cd609ca2 on 1.0.x authored by
Jay Jangid โ
Issue #3340455: Update core_version_requirement in .info file.
-
netboss โ
committed cd609ca2 on 1.0.x authored by
Jay Jangid โ
- ๐จ๐ฆCanada joseph.olstad
I still get this error with composer require:
requires drupal/core ~8.0 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev] but the fixed to 9.5.3
I should be able to install this module with Drupal 9.5.3 however composer is shooting vinaigre on the party.
- ๐จ๐ฆCanada joseph.olstad
Perhaps a tagged release would fix this problem, such as 1.0.0-beta1 ?
- ๐จ๐ฆCanada joseph.olstad
Until this is fixed, I've cloned and forked this project in my own project and changed composer to use a local path instead of drupal
- Status changed to Needs work
about 2 years ago 3:06pm 7 March 2023 - ๐บ๐ธUnited States mkinnune
I've tried doing a tagged release, but it doesn't seem to have helped. I'd be okay with completely dropping support of drupal 8 with this module and changing the core version requirement to instead just include 9 and 10:
core_version_requirement: ^9 || ^10
- ๐บ๐ธUnited States netboss New Smyrna Beach, FL
mkinnune โ credited netboss โ .
- ๐จ๐ฆCanada joseph.olstad
yes please drop D8 support, this should fix the issue.
- First commit to issue fork.
- @elber opened merge request.
- Status changed to Needs review
about 2 years ago 6:01pm 7 March 2023 - Status changed to Needs work
about 2 years ago 6:29pm 7 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+core: 8.x
core_version_requirement: ^8.8 || ^9core
cannot be used with the value used forcore_version_requirement
. - ๐ง๐ทBrazil elber Brazil
based in the comments #10 and #11 Does drupal8 support will be dropped?
- ๐จ๐ฆCanada joseph.olstad
@apadermo has the right idea
this line:
core: 8.x
is deprecatedThis line should be ok:
core_version_requirement: ^8.8 || ^9 || ^10
- ๐จ๐ฆCanada joseph.olstad
I just tried this:
composer require 'drupal/content_reminders:1.0.x-dev@dev'
same error,
maybe try removing
^8.8 ||
instead should probably consider adding|| ^10
- Status changed to Needs review
about 2 years ago 11:01am 8 March 2023 - ๐ช๐ธSpain alvar0hurtad0 Cรกceres
Please consider don't provide credits in case of minor contributions (like this comment I'm doing right now)
-
mkinnune โ
committed 526d8f03 on 1.0.x authored by
elber โ
Resolve #3340455 "Update coreversionrequirement in"
-
mkinnune โ
committed 526d8f03 on 1.0.x authored by
elber โ
- Status changed to Fixed
about 2 years ago 7:26pm 8 March 2023 - ๐ง๐ทBrazil elber Brazil
Hi moving to Fixed because the changes have already been commited
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 5:21pm 29 July 2023 - ๐จ๐ฆCanada joseph.olstad
FYI, I added another tagged release with this commit:
https://git.drupalcode.org/project/content_reminders/-/commit/3795c8633f...
now this module should finally be ready for D10.
Our private packagist has a delay takes longer to pick up new releases from Drupals packagist so I'll confirm the tagged release is good asap but have to wait a bit.