Fix the errors/warnings reported by PHP_CodeSniffer

Thanks for testing this @himanshu_jhaloya! Can you please check against the 2.x branch instead 2.0? Some of these issues have been fixed in the 2.x branch.

Hi @mmarler,

I checked 2.x branch and here are the issues reported by phpcs shown below:

FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/bootstrap_horizontal_tabs/README.md
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 8 | WARNING | Line exceeds 80 characters; contains 88 characters
------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/bootstrap_horizontal_tabs/src/Plugin/Field/FieldWidget/BootstrapHorizontalTabs.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
 30 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 38 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 64 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/bootstrap_horizontal_tabs/src/Plugin/Field/FieldFormatter/BootstrapHorizontalTabs.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
  72 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  75 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 148 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 149 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 362ms; Memory: 10MB

I will work this on this.

Created a patch to fix the issues reported by phpcs.

Please review.
Thank You.

The last submitted patch, 7: codingstandards-3339850-7.patch, failed testing. View results →

Hi,

The patch #7 applied cleanly.
All the errors are resolved.
Please check screenshot.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

The report must also be updated for the 2.x branch. In fact, the bootstrap_horizontal_tabs.info.yml file cannot those warnings.

name: 'Bootstrap Horizontal Tabs'
description: 'Provides a custom field type displayed as horizontal tabs'
type: module
core_version_requirement: ^8 || ^9 || ^10
dependencies:
  - drupal:field
  - drupal:text
package: Field
core_incompatible: false

The patch changes less files than it should.

apaderno → changed the visibility of the branch 3339850-14 to hidden.

apaderno → changed the visibility of the branch 3339850-phpcs to hidden.

apaderno → changed the visibility of the branch 3339850-drupal-coding-standards to hidden.

Thanks for the code cleanup, folks!

Automatically closed - issue fixed for 2 weeks with no activity.