Fix the issues reported by phpcs

FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/ses_email_bounce.info.yml ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | [ ] All dependencies must be prefixed with the project name, for example "drupal:" 7 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/config/install/ses_email_bounce.settings.yml -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Expected 1 newline at end of file; 4 found -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/ses_email_bounce.routing.yml ---------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/ses_email_bounce.links.menu.yml ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/README.md --------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 599 characters 22 | WARNING | Line exceeds 80 characters; contains 83 characters 24 | WARNING | Line exceeds 80 characters; contains 260 characters 30 | WARNING | Line exceeds 80 characters; contains 106 characters --------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/ses_email_bounce.links.task.yml ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Expected 1 newline at end of file; 3 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/ses_email_bounce.install ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 3 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/ses_email_bounce/src/Controller/DisplayTableController.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 147 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 151 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines ----------------------------------------------------------------------------------------------------------------------------------------- Time: 442ms; Memory: 12MB

Comments & Activities

Issue created by @Kamlesh Kishor Jha
Assigned to dineshkumarbollu
Comment almost 2 years ago →
🇮🇳India dineshkumarbollu
Issue was unassigned.
Status changed to Needs review almost 2 years ago7:50am 9 February 2023
Comment almost 2 years ago →
🇮🇳India dineshkumarbollu
Hi

I am applied patch for this issue.

thanks please review.
Status changed to Needs work over 1 year ago2:56am 9 June 2023
Comment over 1 year ago →
🇵🇭Philippines paraderojether
Hi I reviewed patch #3, and there are still remaining issues that is reported by phpcs. I'm also getting other errors/warnings.

I updated the summary.
Thank You.
Assigned to nitin_lama
Comment over 1 year ago →
🇮🇳India nitin_lama India
Status changed to Needs review over 1 year ago11:52am 9 June 2023
Comment over 1 year ago →
🇮🇳India nitin_lama India
Patch #3 doesn't applies on 1.1.x branch. Providing updated patch.
Comment about 1 year ago →
arijit acharya
Arijit Acharya → made their first commit to this issue’s fork.
@arijit-acharya opened merge request.
Comment about 1 year ago →
arijit acharya
Added a MR for the phpcs issue.
Please review.
Issue was unassigned.
Comment about 1 year ago →
🇮🇳India kunal_singh
Comment about 1 year ago →
System Message

kunal_singh → committed 18456300 on 1.1.x authored by Arijit Acharya →
Issue #3339196 by Arijit Acharya, nitin_lama, dineshkumarbollu, Kamlesh...
Comment about 1 year ago →
🇮🇳India kunal_singh
MR Merged!!

Thank you everyone for the contribution.
Status changed to Fixed about 1 year ago12:44pm 2 November 2023
Comment about 1 year ago →
🇮🇳India kunal_singh
Status changed to Fixed about 1 year ago8:46pm 2 November 2023
Comment about 1 year ago →
🇮🇳India kunal_singh

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Comments & Activities