- Issue created by @thomas.frobieter
- Assigned to Anybody
- 🇩🇪Germany Anybody Porta Westfalica
I split tabs and slideshow container into two issues, as tabs are not that important for us now and might be harder because of the additional title. We start with container slideshows.
Slideshow (Probably multiple layouts, each with its own Slick Optionset => 6 cols, 5 cols, 4 cols, ... this way we could drop many of the options)
I think this is incorrect, we can't use real layout regions to control the amount of columns. Otherwise we would need to dynamically add regions.
So we simply should have one region and initialize slick on it. All direct childs will be single slides. So the required options are similar to the old ones.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @anybody opened merge request.
- Status changed to Needs review
over 1 year ago 12:38pm 14 July 2023 - 🇩🇪Germany Anybody Porta Westfalica
Remaining:
- [] Write an install hook for the submodule to rename the old container to suffix DEPRECATED when installing this module. We won't be able to replace the old containers programmatically. - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to thomas.frobieter
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter go for it in the demo! :)
Okay, thought about this again ;)
We only need one setting from the DROWL Layout default layout settings, this is the section width.
So, lets add this here again, next to the slideshow settings [2]:
The layouts on top, should reflect our default layouts + a custom one [1]:
- 1 col
- 2 col
- 3 col
- 4 col
- 5 col
- 6 col
- custom
The available settings should be:
- For all:
- Section Width
- Background (the whole fieldset with all fields)
- Show Arrows (default true)
- Show Dots (default false)
- Show Controls outside (default false)
- Autoplay (default true)
- Automatic Height (default true)
- Infinite (default false)
- Center Mode (default false)
- Custom only:
- Visible Elements: Small Devices
- Visible Elements: Medium Devices
- Visible Elements: Large Devices
All these layouts are technically the same, they have one single region and only differs in its slick settings.
I think this will be the best possible user experience.- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to Anybody
@anybody I've added the required layouts. I think the next step should be adding the fields?
I've already created Twig "slideshow_attributes" in the 1col template. Not 100% sure if we should do it there or in php. Depends on where we add the Slick attributes .. 51% for the template. Probably easier this way, to modify those on the Theme side, if required.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs work
over 1 year ago 10:36am 27 September 2023 - Assigned to thomas.frobieter
- Status changed to Needs review
over 1 year ago 3:11pm 27 September 2023 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter please review the MR and afterwards proceed! :)
@anybody: One configuration thing here, the layouts where not selected after installing the submodule:
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter config isn't ready yet. You first have to finish and afterwards I'll export and align the config.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to Anybody
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to thomas.frobieter
- Status changed to Needs work
over 1 year ago 12:07pm 5 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter I left some comments, please solve what you can solve yourself and leave the rest to me or @Grevil.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to Anybody
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to thomas.frobieter
- 🇩🇪Germany Anybody Porta Westfalica
Left further comments. Others were not resolved yet.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to Anybody
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter could you care for
- [] Ensure all previous functionalities & possibilities exist - [] Test
please?
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to thomas.frobieter
- Status changed to Needs review
over 1 year ago 6:00pm 17 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter ALL DONE (hopefully!)
Ready for final testing!Afterwards we can merge this into dev and test it in-depth at DRC!
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs work
over 1 year ago 5:14pm 18 October 2023 - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to Anybody
- Status changed to Needs review
over 1 year ago 9:23am 19 October 2023 All fixed, please review again!
I needed to do alot of modifications:
1) I've assigned all values with its fallback values to variables, because we need to add the settings to each Slick Breakpoint (like it is with the Slick UI module), this seems to be a weird Slick Carousel thing
2) Changed the method passing fallback values to boolean fields, because "0" is a valid value, so we cant use (not) empty() as condition
3) Added a flag (like we have it in drowl_layouts), to figure out, if the layout is shown in a preview/edit mode: drowl_paragraphs_layout_in_preview. We need this, because we need to wrap the single slides into a div.slick__slide wrapper in the frontend, to match the default Slick Module markup.
I think the most "unclean" part here is this (layouts/drowl-paragraphs-slideshow--1col.html.twig):{% for slide in content.slides %} {# Ensure its a render array (and not attributes or something) #} {% if slide['#theme'] %} <div class="slick__slide"> {{ slide }} </div> {% endif %} {% endfor %}
Better ideas welcome. I think the {% if slide['#theme'] %} should reliably ensure, that we only render renderable array entries (paragraphs). We could also explicitely check for the paragraph entity..
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to thomas.frobieter
- Status changed to Needs work
over 1 year ago 10:51am 23 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter: Left 2 final comments, after that we can set this RTBC and merge it into 4.x for heavy testing. I'd suggest merging it once you have the time for that, because we'll block a new 4.x release for some time.
- Assigned to Anybody
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to RTBC
over 1 year ago 2:10pm 23 October 2023 - Issue was unassigned.
- Status changed to Fixed
over 1 year ago 2:11pm 23 October 2023 - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to Grevil
- Status changed to RTBC
over 1 year ago 4:23pm 23 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
Sadly blocked by rebase needed. @Grevil will do that tomorrow!
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass -
Anybody →
committed 0affe4d8 on 4.x
Issue #3339002: Change "Container-Slideshow" to be Layout
-
Anybody →
committed 0affe4d8 on 4.x
- Assigned to thomas.frobieter
- Status changed to Fixed
over 1 year ago 2:45pm 25 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter finally merged (by simple merge instead of rebase).
Please do heavily testing, as there's a risk I broke something. Especially before we do any other release, this needs to be tested extensively.Thank you!
Automatically closed - issue fixed for 2 weeks with no activity.