- Issue created by @Anybody
- Status changed to Postponed
over 1 year ago 12:20pm 11 July 2023 - 🇩🇪Germany Anybody Porta Westfalica
Postponed on ✨ Introduce layout_slideshow layout paragraph type and deprecate old "container_slides" paragraph Needs work
Further consideration on this topic: The layout should not live in drowl_paragraphs, it should live in drowl_layouts, because we also want to have the drowl_layout settings on the layout.
@anybody you decide whats the cleaner approach here. I think drowl_paragraphs should only provice the layout-slideshow paragraph type with its configuration. drowl_layouts provides the slideshow-layout(s), with the slideshow settings fields (this time programmatically added fields, not entity fields).
We might could do all of this in drowl_paragraphs .. if we are able to get the drowl_layouts layout settings in any way.
- Assigned to thomas.frobieter
- Status changed to Active
over 1 year ago 6:19am 27 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter both is fine for me. The point is from my perspective, if these layouts are drowl_paragraphs specific (and shouldn't / wouldn't be used outside), then they should be part of the drowl_paragraphs submodule that installs the type.
If they are general enough, put them into drowl_layouts, as drowl_paragraphs depends on drowl_layouts.
You can prepare the changes suggested here in our DEMO. But please do NOT CHANGE THE EXISTING Tabs, instead create a new one: layout_tabs similar to the new layout_slideshow.
We'll deprecate the old paragraphs, so we don't need an automatic migration and don't risk to break things. If we'd like to delete the old paragraph types one day, we can use a view to look up, where they were used and replace them manually.Doing this automatically would be super hard and still dangerous.
Go for it :)
Okay, thought about this again ;)
We only need one setting from the DROWL Layout default layout settings, this is the section width.
So, lets add this here again, next to the slideshow settings [2]:
The layouts on top, should reflect our default layouts + a custom one:
- 1 col
- 2 col
- 3 col
- 4 col
- 5 col
- 6 col
- custom
The available settings should be:
- For all:
- Section Width
- Background (the whole fieldset with all fields)
- Show Arrows (default true)
- Show Dots (default false)
- Show Controls outside (default false)
- Autoplay (default true)
- Automatic Height (default true)
- Infinite (default false)
- Center Mode (default false)
- Custom only:
- Visible Elements: Small Devices
- Visible Elements: Medium Devices
- Visible Elements: Large Devices
All these layouts are technically the same, they have one single region and only differs in its slick settings.
I think this will be the best possible user experience.Well, this was the wrong issue ;) Moved to ✨ Introduce layout_slideshow layout paragraph type and deprecate old "container_slides" paragraph Needs work
- Status changed to Postponed
over 1 year ago 12:15pm 27 September 2023 As just discussed with @Anybody this is nothing important (for now). We don't use this type frequently and it's well designed the way it is. Just the drag & drop support is missing.
If we should decide to implement this one day, we should solve this similar to what we did in ✨ Introduce layout_slideshow layout paragraph type and deprecate old "container_slides" paragraph Needs work , but:
- We just need one layout "Tabs / Accordion" (living in the submodule, not in drowl_layouts)
- layout_tabs_accordion paragraph type only allows that one layout to be selected
- We need to limit the allowed types within the layout_tabs_accordion paragraph type using https://www.drupal.org/project/layout_paragraphs_limit → to one type: "Accordion / Tab item" which holds the tab / accordion title. This one allows all regular layouts (like first class layout paragraphs) so that the contents can be placed into its layout and allows Drag & Drop
- The selection to show as accordeon vs. tabs should be a layout setting
All these points should be first tested in a prototype, before we put the effort of config etc. into it!
(Written by JP & TF)So we postpone it until this is really needed in real world!