- Issue created by @mfb
- Status changed to Needs work
over 1 year ago 6:37pm 16 February 2023 - πΊπΈUnited States smustgrave
Could we add a simple test case for this? Not sure if there is one that could be expanded?
- Status changed to Needs review
over 1 year ago 5:29am 17 February 2023 - π³πΏNew Zealand DanielVeza Brisbane, AU
This is a tricky one to decide tests for. We don't have any tests for the
ExtensionMimeGuesser
that I can see.We do have a test for the Audio Media source with
MediaSourceAudioVideoTest
, but.m4a
files aren't even part of the default configuration of an audio field.I'm also not sure how far down the track we want to go with this. Do we add
ExtensionMimeGuesser
tests adhoc as issues come up? There is 350+ extensions in that list.Verified that the code is correct, and the links above do suggest to that
audio/mp4
is the correct mime form4a
files.I'd be happy to RTBC this one, but I'll move it to review for other thoughts around tests
- πΊπΈUnited States mfb San Francisco
can add whatever kind of test is helpful, but generally we just fix the mapping bug without a test, see e.g. β¨ Add support for .FLAC, .OPUS and .AAC audio type of file with HTML 5 audio player Fixed
- Status changed to RTBC
over 1 year ago 4:02pm 18 February 2023 - πΊπΈUnited States smustgrave
Thank you for sharing that. If this is something we don't test won't hold this up.
The last submitted patch, m4a-mime-type.patch, failed testing. View results β
The last submitted patch, m4a-mime-type.patch, failed testing. View results β
The last submitted patch, m4a-mime-type.patch, failed testing. View results β
The last submitted patch, m4a-mime-type.patch, failed testing. View results β
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 10.1.x and backported to 10.0.x and 9.5.x
Thanks folks!
-
larowlan β
committed 5d6bf4a7 on 10.0.x
Issue #3338224 by mfb: .m4a files should use audio/mp4 MIME type, not...
-
larowlan β
committed 5d6bf4a7 on 10.0.x
-
larowlan β
committed 2d38f1ec on 10.1.x
Issue #3338224 by mfb: .m4a files should use audio/mp4 MIME type, not...
-
larowlan β
committed 2d38f1ec on 10.1.x
- Status changed to Fixed
over 1 year ago 7:08am 3 April 2023 -
larowlan β
committed ccc13ec8 on 9.5.x
Issue #3338224 by mfb: .m4a files should use audio/mp4 MIME type, not...
-
larowlan β
committed ccc13ec8 on 9.5.x
Automatically closed - issue fixed for 2 weeks with no activity.