- Issue created by @jay jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:20am 31 January 2023 -
Jay Jangid →
committed ef6319b4 on 8.x-3.x
Issue #3337836: Drupal Coding Standards Issues | phpcs
-
Jay Jangid →
committed ef6319b4 on 8.x-3.x
- 🇮🇳India Adil_Siddiqui
On running phpcs based on drupal standard still got the below errors:
FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/bcc/bcc.module
------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------
4 | ERROR | [x] Doc comment short description must be on the first line
5 | ERROR | [x] There must be exactly one blank line after the file comment
24 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------ - Status changed to Needs work
almost 2 years ago 10:54am 15 February 2023 - 🇮🇳India sidharth_soman Bangalore
Patch #6 fails to apply. Hence, moving back to 'Needs Work'.
I've attached screenshots of the remaining issues before I applied the patch and the error message upon applying it.
- 🇮🇳India Adil_Siddiqui
@sidharth_soman patch applied successfully on my local....Are you using the correct version?
- Assigned to omkar_yewale
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 3:53am 16 February 2023 - 🇮🇳India omkar_yewale Mumbai
#6 patch applied successfully on 8.x-3.x-dev version, but while running phpcs getting below error.
FILE: /web/modules/contrib/bcc/bcc.module
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
42 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------here is the updated patch for the same, please review.
- Assigned to spriya2896
- Status changed to RTBC
almost 2 years ago 6:06am 16 February 2023 - 🇮🇳India spriya2896
Patch #10 failed to apply, But after applying patch #6 only it shows no phpcs Erros. Here is the screenshot for the same.
- Issue was unassigned.
- 🇺🇸United States devkinetic
Thanks for all of the feedback, I will roll this in shortly.
-
omkar_yewale →
authored 1c57fc1d on 8.x-3.x
Issue #3337836 by Jay Jangid, Adil_Siddiqui, omkar_yewale,...
-
omkar_yewale →
authored 1c57fc1d on 8.x-3.x
- Status changed to Fixed
over 1 year ago 5:05pm 10 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.