- Issue created by @sahil.goyal
- ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- Assigned to Charchil Khandelwal
- Merge request !1Issue #3337516: Drupal Coding Standards Issues | phpcs โ (Merged) created by Charchil Khandelwal
- ๐ฎ๐ณIndia Charchil Khandelwal
All warnings and errors are fixed now.
Created MR for same.
Please review. - Issue was unassigned.
- Status changed to RTBC
about 2 years ago 3:17am 2 May 2023 - ๐ต๐ญPhilippines paraderojether
Hi Charchil Khandelwal
I reviewed MR!1, and confirmed it fixes the issue reported by the phpcs. Drupal core version 9.5.8, Workbench Reviewer 3.0.0-beta1.
I added screenshots for reference.
Thank You. - Status changed to Needs work
about 2 years ago 9:04am 2 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
function workbench_reviewer_entity_presave(EntityInterface $entity) { if ($entity->getEntityTypeId() === 'node') { - $node = $entity; + // $node = $entity; } }
If a line must be removed, it is not commented out.
- Assigned to himanshu_jhaloya
- ๐ฎ๐ณIndia himanshu_jhaloya Indore
Created patch for the commented issue. please review
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 11:33am 2 May 2023 - last update
about 2 years ago Patch Failed to Apply - First commit to issue fork.
- last update
about 2 years ago 1 pass - Assigned to abhinesh
- Status changed to RTBC
12 days ago 8:20am 12 June 2025 - ๐ฎ๐ณIndia abhinesh
Thank you for your contribution's! Merging it into the development branch now.
-
abhinesh โ
committed 4f5af664 on 3.0.x authored by
Charchil Khandelwal โ
Issue #3337516: Drupal Coding Standards Issues | phpcs
-
abhinesh โ
committed 4f5af664 on 3.0.x authored by
Charchil Khandelwal โ