Created on 26 January 2023, almost 2 years ago
Updated 23 October 2023, about 1 year ago

Please fix info.yml

โœจ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡ท๐Ÿ‡บRussia xandeadx

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @xandeadx
  • Assigned to sahilgidwani
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sahilgidwani Jaipur

    I am working on this issue.

  • @sahilgidwani opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sahilgidwani Jaipur

    I have made the required changes and checked on D10, it is working fine. Also, I have updated the readme.md according to the latest standards also.
    Moving it to needs review.

  • Status changed to RTBC almost 2 years ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany J-Lee ๐Ÿ‡ฉ๐Ÿ‡ช๐Ÿ‡ช๐Ÿ‡บ

    Looks good to me.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vipin.j

    vipin.j โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vipin.j

    This merge request was missing Drupal 10 migration support in composer.json file, which further affects building dependencies in site's composer.lock. which means currently in site's composer.lock the require is still lock to D8 & D9, i.e. "drupal/core": "^8 || ^9".

    So, to migrate from existing Drupal 9 site to Drupal 10, it should also be compatible with ^10, which can be managed by module's composer.json.

    with #7 commits, now the generated .diff file is failing with composer-patches on release version 8.x-1.1, because of the # Information added by Drupal.org packaging script on 2020-06-23 details in commerce_checkout_order_fields.info.yml, conflicts with the changes done by the commits.

    I have tried to fix the composer patch application failure with this patch. this will help in removal of conflict with dependencies and the last commits. We still wait for the merge request to be approved for next stable D10 release.

  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany sleitner
  • ๐Ÿ‡น๐Ÿ‡ญThailand AlfTheCat

    Patch applied was able to install the module :)

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany sleitner

    @harings_rob please get a D10 version released.

  • ๐Ÿ‡ฎ๐Ÿ‡นItaly ConradFlashback

    Please commit

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States rhovland Oregon

    I attempted to contact the maintainer via slack and have received no response. Someone who can opt into security coverage needs to apply to be a maintainer of this module.

  • Well we have about a month before this is end of life, support ends for Drupal 9 in November 2023, and it already ended for Drupal 8.

    This module will not install with composer on Drupal 10.

  • ๐Ÿ‡ฆ๐Ÿ‡นAustria mathiasgmeiner

    The patch from #8 works fine for me as well.

  • ๐Ÿ‡ซ๐Ÿ‡ฎFinland simohell

    @webengr we can use
    https://github.com/mglaman/composer-drupal-lenient to allow composer to install older versions in order to pach them.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States hyperlinked San Jose, CA

    @webengr and @simohell you can also add this issue repo as a custom git repo to composer.json and install the specific branch you want. So your repositories would look something like:

    "repositories": {
            "commerce_checkout_order_fields": {
                "type": "git",
                "url": "git@git.drupal.org:issue/commerce_checkout_order_fields-3336589.git"
            },
            "drupal": {
                "type": "composer",
                "url": "https://packages.drupal.org/8",
                "exclude": ["drupal/file_download","drupal/commerce_checkout_order_fields","drupal/filter_twig"]
            }
    
        },

    And you would then specifically install the Drupal 10 compatibility branch like so:
    composer require drupal/commerce_checkout_order_fields:dev-3336589-drupal-10-support

  • ๐Ÿ‡ง๐Ÿ‡ชBelgium ndesmedt

    @hyperlinked

    I've updated composer.json with your sugestion. Then I ran the command:
    composer require drupal/commerce_checkout_order_fields:dev-3336589-drupal-10-support

    But no luck, I have the following error:

    [RuntimeException]
      Failed to execute git clone --mirror -- git@git.drupal.org:issue/commerce_checkout_order_fields-3336589.git C:/Users/did42/AppData/Local/Composer/vcs/git-git.drupal.org-issue-commerce-checkout-order-fields-
      3336589.git/
    
      Cloning into bare repository 'C:/Users/did42/AppData/Local/Composer/vcs/git-git.drupal.org-issue-commerce-checkout-order-fields-3336589.git'...
      Warning: Permanently added the ECDSA host key for IP address '44.230.112.158' to the list of known hosts.
      git@git.drupal.org: Permission denied (publickey).
      fatal: Could not read from remote repository.
    
      Please make sure you have the correct access rights
      and the repository exists.

    I don't know how to solve this.

  • First commit to issue fork.
  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    7 pass
  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    7 pass
  • Status changed to Fixed about 1 year ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

    Thanks @vipin.j nice work! Made some minor adjustments and will merge this now!

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024