Olivero: use multi-class array for adding multiple classes in block--search-form-block.html.twig template

Created on 25 January 2023, over 1 year ago
Updated 19 February 2023, over 1 year ago

Olivero: use multi-class array for adding multiple classes templates

We are adding multiple classes by single array.
<div{{ content_attributes.addClass('content', 'container-inline') }}> We should add multiple classes by multi-class array.

To make it consistent we can use multi-class array.

Remaining tasks

Update mutli-class array in these files:
search-result.html.twig
node.html.twig
book-tree.html.twig
menu--primary-menu.html.twig
menu--secondary-menu.html.twig
menu-local-task.html.twig
menu.html.twig

User interface changes

None

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Olivero  →

Last updated about 8 hours ago

Created by

🇮🇳India Gauravvv Delhi, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Gauravvv
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India Gauravvv Delhi, India

    Added a patch with multi array class. Please review

  • Status changed to RTBC over 1 year ago
  • 🇮🇪Ireland markconroy

    Looks good to me, applies cleanly. Tested against D10-dev.

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Lets update the issue summary as to why there is interest in making this change. If it's for consistency, the scope should probably be expanded to other templates using multiple args.

    search-result.html.twig
    node.html.twig
    book-tree.html.twig
    menu--primary-menu.html.twig
    menu--secondary-menu.html.twig
    menu-local-task.html.twig
    menu.html.twig
  • 🇮🇳India Gauravvv Delhi, India

    Updated IS.

  • @gauravvv opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India Gauravvv Delhi, India

    Addressed #4 and created MR. Please review

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    MR 3471 seems to have some failures

    May be the templates that are going through loops..

Production build 0.69.0 2024