- Issue created by @pcambra
- First commit to issue fork.
- First commit to issue fork.
- Status changed to Needs review
about 2 years ago 7:11pm 27 January 2023 - @rpayanm opened merge request.
- Status changed to Needs work
about 2 years ago 4:05pm 28 January 2023 - Status changed to Needs review
about 2 years ago 10:01pm 30 January 2023 - Status changed to Needs work
about 2 years ago 11:12am 31 January 2023 - πͺπΈSpain facine
Hi! I would just add a small comment.
If an administrator changes these settings, we should expire the cache.
So I think we need to add also the dependency to the settings object.
$settings = $this->config('like.settings') $response->addCacheableDependency($settings);
- Status changed to Needs review
about 2 years ago 7:01pm 3 February 2023 -
pcambra β
committed 39d1f016 on 1.x authored by
rpayanm β
Issue #3336092: Use the configurable cookie lifetime for the like...
-
pcambra β
committed 39d1f016 on 1.x authored by
rpayanm β
-
pcambra β
committed 960fb521 on 2.x authored by
rpayanm β
Issue #3336092: Use the configurable cookie lifetime for the like...
-
pcambra β
committed 960fb521 on 2.x authored by
rpayanm β
- Status changed to Fixed
about 2 years ago 10:05am 4 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.