- Issue created by @rymcveigh
- Status changed to Postponed: needs info
almost 2 years ago 1:30am 24 January 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
I am willing to make a small bet this regression is being triggered by 🐛 [Drupal 9.2.x] Replace jquery.removeOnce with new once API Fixed .
- 🇺🇸United States rymcveigh
I am willing to make a small bet this regression is being triggered by #3335861: [Drupal 9.2.x] Replace jquery.removeOnce with new once API.
It actually happens on the current 6.2@beta release of webform as well as the 6.2.x branch. So I do not think they are related.
I am able to reproduce this issue using Drupal 10 with PHP 8.1 using the composer installed 6.2@beta version on the module (that doesn't have the removeOnce adjustment). But, the removeOnce function doesn't work on D10 anyway so... I gues it could be a regression... 🤷
In any case, the current version of dev works okay on Drupal 9.5. This bug seems to be related to a change in core.
- Status changed to Active
almost 2 years ago 11:27pm 31 January 2023 - 🇺🇸United States greggles Denver, Colorado, USA
Setting back to active based on the research and feedback in #4.
- Status changed to Needs review
over 1 year ago 4:05pm 24 March 2023 - 🇷🇺Russia selpi
Thanks a lot, patch in #6 fixed the problem with file/image upload element. Without it placing file/image upload element to a form page with another element that allows to add more rows for example was breaking the form (adding was not working with ajax error).
- 🇺🇸United States jrockowitz Brooklyn, NY
Using
Drupal::request()->request->all('files')
returns all form values and triggers the code for every request. The root cause needs to be diagnosed. - 🇺🇸United States Topplestack Rural, Idaho
I'm getting the same error message after uploading an image and then trying to remove selected image. #6 does not resolve the issue. Could be separate issue, but based on the current information, they appear to be related.
I get the same error (recorded in the logs) when I select my file which loads then I click on "submit" then, it displays this message:
" File upload in progress. Uploaded file may be lost.Do you want to continue?"
If I click "Continue", then my form is "reset" I can't load a file
On the other hand, when I use the TEST option of the form, I no longer have an error displayed and the test file is load.- Status changed to Needs work
over 1 year ago 12:15pm 24 May 2023 - 🇨🇭Switzerland berdir Switzerland
> Using Drupal::request()->request->all('files') returns all form values and triggers the code for every request. The root cause needs to be diagnosed.
I think there's not much to be diagnosed.
Symfony 5/6 deprecated/removed the ability to return non-scalar values, you need to use all() for that. No way around that.
However, the patch is wrong, all() has no argument, intead you need to check the return value for the array key files.
- Status changed to Needs review
over 1 year ago 8:13am 8 June 2023 - last update
over 1 year ago 534 pass - Status changed to RTBC
over 1 year ago 9:16am 8 June 2023 - 🇨🇭Switzerland berdir Switzerland
Yeah, confirmed to work on our project.
Could also be inlined into the !empty() or the other check could also use $request_params then, but this works.
- Status changed to Fixed
over 1 year ago 12:08am 10 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.