Fix the issues reported by phpcs

Fix coding standard.

I had Reviewed the MR!2 and it's working as expected mentioned in comment #14

@himanshu_jhaloya

Please don't open MRs where you commit code in your name that was contributed to someone else in a patch before. You will not get credit for that and I can't merge the MR because you are not the author of that code.

@Rashmisoni

Thank you for your patch. Why do you think the changes to the template file are needed? I don't see that in the original report in the issue summary.

@feyp I created MR instead of patch can be easier to review the code.it is not just about the get credit.
thanks

@himanshu_jhaloya An MR is not easier to review than a patch and it is not easier to merge an MR than to commit a patch. Your unnecessary MR only causes more noise in the issue, makes it less clear and increases the workload of other community members including me as a maintainer of this project.

If this was really not about getting credit for the work done by someone else, you could have committed their code in their name and clearly mentioned in a comment that you just committed their code.

Please stop these unhealthy contributions. It is not helpful. Thank you.

@FeyP: Thanks for reviewing the patch and MR. Both MR and Patch only contain README.md file and the changes are made in README.md in line 90 and 101 due to PHPCS issues.

@Rashmisoni Ah, thanks. Those changes I mistakenly thought were in a template file at first glance are actually in the example code in the README. Sorry about that. Back to RTBC.

Committed thanks.

Credit for:
- Samit Khulve for the original issue report and patch.
- Alberto Paderno for the work as a moderator on this issue.
- rashmi soni for the reroll of the patch and constructive comments.
- Ranjit Sahoo for reviewing MR 2 that was identical to patch #13. Normally reviewing and RTBC-ing code contributed by a colleague working at the same company is discouraged, but in this case it was not immediately visible since the MR was created by a community member from a different company committing the same code under their own name, so I'll still give credit for this review.
- Myself for various reviews, final review before commit and commit.

No credit for:
- Himanshu Jhaloya due to the reasons explained in #11 and especially #16.
- Sonal Gyanani. Normally, I would have given credit for the review in #5, but per #11 MR 1 originally had the same problems as #16 and I just can't give credit for that.
- omkar yewale due to the reasons explained in #11.

I encourage everyone, who didn't get credit this time, to read 5 simple tips to increase your Drupal contributions without gaming the system by Lee Rowlands. Feel free to also forward this article to your management, if you worked on this issue for your company. You can also review How is credit granted for Drupal core issues → . This applies to Drupal core, but is also a good guideline for working on projects like this one. I welcome your constructive contributions in the future. Thank you!

FeyP → closed merge request !1

FeyP → closed merge request !2

Automatically closed - issue fixed for 2 weeks with no activity.