- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 8:39am 18 January 2023 - Status changed to RTBC
almost 2 years ago 7:46pm 18 January 2023 - Status changed to Needs work
over 1 year ago 3:05pm 24 April 2023 - 🇺🇸United States samuel.mortenson
The .txt version is used for auto-generating help text for the module.
- First commit to issue fork.
- Assigned to akshaydalvi212
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:13pm 26 April 2023 - 🇮🇳India akshaydalvi212
Now the Help text will be auto-generated by using README.md file.
kindly review the MR. - 🇺🇸United States samuel.mortenson
@akshaydalvi212 Did you manually test this? I'm not sure I want markdown rendering in hook_help (unless that's available in core), but there was a chunk of code that converted .txt formatting to HTML which isn't removed in your MR.
- 🇺🇸United States bluegeek9
I don't think core has the ability to render markdown. The markdown project can.
Markdown filter → : When enabled, display of the project's README.md help will be rendered with markdown.
@samuel.mortenson Do you want the `preg_replace` removed from `moderation_note_help`. Does the module need a hook_help()?
- Assigned to akshaydalvi212
- 🇮🇳India akshaydalvi212
hey @samuel.mortenson and @bluegeek9,
I tested it manually on my local and provided the screenshot of the same.
as per @bluegeek9 suggestion i can use the markdown filter approach to render the README.md file as well
will update the MR according.
Thanks for the feedback. - Issue was unassigned.
- 🇮🇳India akshaydalvi212
Added the markdown filter and optimized the code in MR.
kindly review. - 🇺🇸United States bluegeek9
Hi @akshaydalvi212,
I think the entire moderation_note_help() function should be removed. It only provides help for one route, help.page.moderation_note, and the help is just the README. If help text is not provided for help.page.moderation_note, and the Markdown module is enabled, the README.md will automatically be the help text for help.page.moderation_note
- Status changed to RTBC
over 1 year ago 11:52am 1 June 2023 - last update
over 1 year ago 5 pass -
bluegeek9 →
committed f6d92d97 on 8.x-1.x authored by
Sonal Gyanani →
Issue #3334422 by akshaydalvi212, Sonal Gyanani, bluegeek9: Replace...
-
bluegeek9 →
committed f6d92d97 on 8.x-1.x authored by
Sonal Gyanani →
- Status changed to Fixed
over 1 year ago 11:10pm 10 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.