Breadcrumb for local tasks of Custom Blocks should contain the name of the custom block not the entity ID

isset() has been removed from AssertBreadcrumbTrait

Fact it passes makes me thing it was a true unneeded check.

Thanks for all the work you've done on this!

Looks good to me so sending to the next level.

Discussed with @alexpott and we agreed that the fix for the PHPStan warning wasn't right. The fix would have caused bunch of contrib testing to break: https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs.... If we want to fix the PHPStan warning, we should probably just change the docs to allow null. We have already marked it as optional, so in practice it is an allowed type even though it's not listed.

Either way, we should probably avoid making this change here, and instead file a new issue for this. I reverted the most recent commit that introduced these changes. I will wait until there is a passing test run.

lauriii → closed merge request !3257

Committed bfe3f5d and pushed to 10.1.x. Thanks!

Hey @lauriii, just opened a followup as per #17, it would be nice to have a review there.
📌 Fix PHPStan warning on assertBreadcrumb when passing NULL Fixed

Thanks everyone, this is a small but great usability improvement, nice work!

Automatically closed - issue fixed for 2 weeks with no activity.