Fix pager h4 for accessibility on Stable9

Since this is an accessibility fix I think it should be made in Stable9. The non stable9 themes are updated in an RTBC Patch: https://www.drupal.org/project/drupal/issues/3333401 🐛 Pager h4 causes accessibility flag on many pages Fixed

Seems like this is a pretty low risk change so I'd be fine with introducing this change in 10.1.x. Removing needs accessibility review tag since the approach was already reviewed in 🐛 Pager h4 causes accessibility flag on many pages Fixed .

I think so long as we have the stable base themes, changes to them in minor releases should get release notes

Please let me know if you need additional information in the release note, this is my first time attempting one on core.

In order to prevent heading out of order accessibility errors on views pagers the h4 was removed from the pager and views mini pager template in Stable9. This should not affect most sites since the element was hidden by default. The aria attributes were moved to the preexisting nav element.

Postponing this issue. It was filed as a follow-up to 🐛 Pager h4 causes accessibility flag on many pages Fixed , which was committed and later reverted.

Since then, I've made a very strong objection to the proposal in 🐛 Pager h4 causes accessibility flag on many pages Fixed . I don't think we should remove the heading.

So, this issue isn't currently needed, and may well turn out to be a wont-fix.

I think we can keep this open, I'm going to attempt making it configurable which would still be a benefit here.

I think the parent issue is getting close to be resolved. I think since this is an accessibility fix and we've found an acceptable way to update the other core themes, it makes sense to make the change to Stable9 once it lands and utilize the variable for heading level that views is providing. Otherwise the setting in views will have no affect.

I still need to wait for the parent issue to land cause the tests are all there.

I'll create a new MR once that is merged.

nicxvan → closed merge request !3283

nicxvan → changed the visibility of the branch 3333418-stable9-accessibility-update to active.

This can only be added in 10.3+ since it relies on https://www.drupal.org/project/drupal/issues/3333401 🐛 Pager h4 causes accessibility flag on many pages Fixed which is coming out in 10.3

Tests are passing so this is ready for review.

I believe with changes to stable9 we will need a CR for the new/edited templates. As themes built with starterkit will have to update their code right?

Starterkit was updated in the previous issue, I just tested generating a new theme on HEAD and the new theme uses the pagination heading variables even though stable9 hasn't been updated. Both templates that were edited are in the generated theme so they wouldn't fall back to stable9.

Anyone who created a theme with the generator before 10.3 will need to update their templates to use the new variable which is mentioned in the parent change record.

I'll create a draft CR just in case.

Change LGTM thanks for adding CR.

I'm triaging RTBC issues → . I read the IS and the comments.

The issue summary states that there are "accessibility review guidelines" in [#33333401] but I can not find them. Is that the correct link?

In #10 @andrewmacpherson suggested this is a won't fix but then I read that the related issue was committed and nicxvan restarted the work here. I then read the MR and I have no suggestions. My reading of the MR is not a review.

I read the change record and it reads as if the new configuration was added in this issue. But, according to this change notice → that was added in another issue. That needs to be clarified, so that this change record is only for the change being made here. Also, "Introduced in branch: 11.x" should be '10.3.x' because 11.x is not a branch, it is really 'main' but we have limitations on d.o such that we can't use 'main'.

I am setting to needs work for the change record updates. That shouldn't take too much time for anyone.

Fix links in the issue summary

Try for a better title

I have updated the change record to be clearer that the configuration option was added in another issue and that this issue is just to take advantage of the new configuration.

If it is not clear @andrewmacpherson's objection was to the originally suggested approach and not the final approach.
His comment in 10 is related to that approach.
We were able to get a more robust solution that resolves his concerns and the initial issue in 🐛 Pager h4 causes accessibility flag on many pages Fixed and this issue is updating Stable9 to take advantage of the accessibility fix and update tests to cover stable.

CR updates look good to me. Link points to the first CR where the setting was added and CR seems to correctly mention this is a stable9 updat.e

nod_ → closed merge request !6071

Committed ecac251 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.