[META] Javascript and YML coding standards

So are we in agreement to break up this ticket to cover each file (or 2 files a ticket) in separate issues.

Yes definitely break it up into more manageble child issues. Maybe start with module_filter.modules_uninstall.js and module_filter.permissions.js because (a) they are smaller and focussed on a single task, and (b) we know we have test coverage for them.

Maybe one file per ticket is a good idea? I can see these issues taking a while to resolve, so one per ticket will minimise the rebasing we have to do if other commits are done in the meantime. We may also make commits part way through even if there are still some problems not resolved.

Opened up 3 sub tickets and changed this to a meta.

Re-ordered to issue number, to match the sequence as shown in side block.

Wonder if we should restart some of these with gitlab? Plan on looking at this module some next week.

Good idea. I have opened 📌 Add gitlab_templates pipeline file Active

The three coding standards child issues have now been completed.

But leaving this meta issue open as we still have 📌 Fix prettier formating warnings in javascript files Active

We can use this meta for testing after the last one lands.

Okay everything is merged and passing.

Lets use this ticket for some last minute testing of all the changes.

I've added a new child issue 📌 Check prettier formatting in .yml files Active because currently all .yml are ignored. We should be able to fix them, I've done it on other contrib modules.

Updated IS.

So my initial testing I don't see anything broken. Think we are good to tag a release?

This meta is fixed. There are no others that are 'needs review' so nothing that is nearly ready. So yes a new release would be great, as 4.0.1 was released Dec 2022.

According to https://drupal-mrn.dev/ from 4.0.1 to 4.x there are 24 issues resolved. So were you thinking of releasing 4.0.2 or is there enough to warrant 4.1.0?

I'm thinking 4.1.0 as we changed a lot

Just tagged a release. Thanks for all the contribution!

Great that we have a new release. It's a pleasure to help.

Automatically closed - issue fixed for 2 weeks with no activity.