- Issue created by @jonathan1055
- Merge request !40Issue #3412888 Coding standards and prettier formatting in .yml files → (Merged) created by jonathan1055
- last update
over 1 year ago 3 pass, 1 fail - last update
over 1 year ago 3 pass, 1 fail - last update
over 1 year ago 3 pass, 1 fail - 🇬🇧United Kingdom jonathan1055
The MR is good. The .yml formatting is fixed via the downloadable patch on the other gitlab_templates MR. It failed in the final run only because that MR is a work-in-progress and I have not yet figured out how to make the .patch artifact optional (the job failed because there was no generated .patch of fixes, because there was nothing to fix :-)
We need to remove the attempted drupalCI testing, now that the drupalci.yml file has been deleted. @smustgrave as maintainer, you can edit the automated testing for the project and delete the "tested on commit. issue testing default" test. Interesting that we are getting a deprecation warning at 10.2. Maybe do not delete the test until we've fixed that one (on a separate issue)
- last update
over 1 year ago 3 pass, 1 fail - last update
over 1 year ago 3 pass, 1 fail - last update
over 1 year ago 3 pass, 1 fail - Status changed to Needs review
over 1 year ago 4:33pm 6 January 2024 - 🇬🇧United Kingdom jonathan1055
Ready for review. The MR eslint job passes without ignoring any .yml files now.
- last update
over 1 year ago 4 pass - Issue was unassigned.
-
smustgrave →
committed 66291e85 on 4.x authored by
jonathan1055 →
Issue #3412888 Coding standards and prettier formatting in .yml files
-
smustgrave →
committed 66291e85 on 4.x authored by
jonathan1055 →
- Status changed to Fixed
about 1 year ago 5:03pm 7 January 2024 - 🇺🇸United States smustgrave
Changes seem fine to me.
Love seeing all the green.
- 🇬🇧United Kingdom jonathan1055
:-)
I will work on the deprecation problem too.
Automatically closed - issue fixed for 2 weeks with no activity.