Fix prettier formating warnings in javascript files

This is looking good. I've modified the gitlab pipeline to output a patch of eslint fixes, which I downloaded and applied locally. I have left two eslint chnages unfixed, to demonstrate the process. This is not for merging yet.

This change to the eslint job might also get added into the standard gitlab_pipelines file, for use by others.

Why are we removing .eslintrc file?

Ah, that was for investigation only. Sorry, this was not really 'ready for review'. The commit message does say "(temp) remove customised .eslintrc config, so that we inherit from core". I wanted to ask you about the customisations and what was actually different between the recently added .eslintrc file the config that would be inherited from core if that file does not exist.

When I started on generating a patch for the the fixable eslint problems, I nocticed that the "fixes" for .yml files were wrong, and that some .yml errors were not reported in the first place. With the customised .eslintrc removed the .yml fixes were all back to as expected. But we got more .js problems. So clearly the customisations you have added in .eslintrc are good to keep, but we also need to fix it for .yml errors.

smustgrave → closed merge request !34

smustgrave → reopened merge request !34

I'm open to just dropping drupalCi thoughts?

Yes, lets drop drupalCI. Just delete the file, I presume?

Woo! All green

Three greens. Excellent!

I've worked a bit on the gitlab_templates project, so I just happened to know about the defaults. For info, the defaults can be checked in gitlab_templates includes/include.drupalci.main.yml

If a job does not specify any allow_failure the the implicit value is false, which means if the job gives a non-zero return code it will show as red. The defaults for phpcs, phpstan, stylelint, eslint, phpunit (next minor) and phpunit (next major) have been set to true so that if any of these jobs return a non-zero code they are didsplayed as a amber warning, not a red failure. The main phpunit job has no allow_failure, so the implicit false is in effect, meaning that a phpunit job failure would be shown as red.

All of these can be overridden by a contrib project's .gitlab-ci.yml file, and it is totally the choice of the maintainers how they wish to display job failures - either amber warning or red failure. In module_filter we set some of the jobs to allow_failure: true when we knew about the style warnings, so that if that was the only thing wrong then the overall test pipeline would be amber not red. This meant that if we ever saw a red it would mean something new or more serious had happened which needed looking at. But now, we have fixed the style jobs, it is good to put them to allow_failure: false so that we are immediately alerted if a new coding standard or style problem is discovered.

Automatically closed - issue fixed for 2 weeks with no activity.