Javascript coding standard (modules, modules_bare, modules_tab)

Surprised a number of errors wonder if that's the right way. Was following my phpstorm.

You have fixed evertything in one hit! Nice work. I don't have phpstorm or eslint, so was doing it bit by bit.

Remember we do not have javascript tests for everything you are changing here, so it will need manual testing.

Was able to fix some the estlin suppressions. Some of them are just not worth it. Like turning this into it's own function variable

function () {
    if (this.activeTab) {
      return this.activeTab;
    }
  };

For about 20 instances.

Added an estlint style file to the repo in the gitlab and got a whole other set of errors (but smaller) so closing this out.

Actually just going to open a new MR.

smustgrave → closed merge request !27

Finally got this to a good state. Merged this for the other tickets/MRs

Automatically closed - issue fixed for 2 weeks with no activity.