- 🇩🇪Germany rkoller Nürnberg, Germany
I've pushed a first draft for the tour tip content. I tried to mind the tour text standards defined here: https://www.drupal.org/docs/develop/user-interface-standards/tour-text-s... → . the first unfocused tour tip describing the whole page is therefore intentionally without a selector and unfocused. some descriptions seem apparent but it has to be kept in mind that screen reader users dont have the extra visual context and information. there are a few open questions:
1. the number of tour tips differs between claro and gin. in claro you have 8 tips while in gin you have 13 (the reason see #8 ✨ Add a tour for the ECA main page Active - when a selector isn't found the tip is simply left out of the tour). question is should the
List of models
be shown at all? or the other way around should the column header tips be shown at all instead?2. except the add new model button i've switched the positioning to an explicit value. for the button in claro it would be best to show it to the right while in gin the button is better shown to the left or the bottom. therefore a clearly defined position doesnt work for that tour tip but for the others it does.
3. and any feedback is welcome in regards of word smithing and details that have to be communicated.
- Status changed to Needs work
over 1 year ago 9:11am 5 February 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
This is looking good to me except that the parameters tab should be removed as it's not provided by ECA. That tour item should be moved to the eca_parameter module.
The column headers are OK as they are now. It's perfect that they adjust to what's possible depending on the active admin theme.
As for the location of the button to add a new model, I don't think we need to bother about that in this issue.
Wording is good to me. And I prefer to move incrementally. That's why I suggest merging this an adopt changes later, if anyone is going to propose any. Otherwise, issues like this remain open forever. IN other words, once the parameter tab is being removed, this would be RTBC to me.
- 🇩🇪Germany rkoller Nürnberg, Germany
the tab is only displayed when eca_parameters is installed. if eca_parameters isnt installed it isn't displayed. and for the case eca_parameters is installed i would leave the tip in for consistency and clarity reasons. all other tabs have a tip so the parameters should have its own imho. that was the reason i've added it in the first place.
and about adding the model and move incrementally. i completely agree but there is one detail i've realized that might make the move incrementally a bit difficult. when eca is already installed with the tip for the main page for example and in a new update that tip is updated those changes aren't available after the update of eca? i've simply changed a tip label manually for a project where eca is already installed and those changes where not in place when i've started the tour (also cleared caches before). is it possible that due to the fact that the tour is config that the config is only loaded on module install and for subsequent updates some config import would be necessary?
- 🇩🇪Germany rkoller Nürnberg, Germany
and i've found the corresponding issue on d.o about tour tips never getting updated: 🐛 Tour tips are provided as configuration, so never get updated Postponed
- 🇩🇪Germany jurgenhaas Gottmadingen
the tab is only displayed when eca_parameters is installed. if eca_parameters isnt installed it isn't displayed. and for the case eca_parameters is installed i would leave the tip in for consistency and clarity reasons. all other tabs have a tip so the parameters should have its own imho. that was the reason i've added it in the first place.
That's technically correct, but still why should ECA have a tour for a third party component in its code? For long term maintenance, it is important to keep things where they belong to.
And for the whole config update questions, this is a very generic topic. Yes, modules that come with config updates have to be aware, that the updated config is not updated on existing Drupal installations. We should not bother about that here, it would only distract us from what we want to achieve here.
- Status changed to Postponed
about 1 year ago 9:55am 30 June 2023 - Status changed to Active
7 months ago 4:04pm 22 February 2024