- ๐ฆ๐บAustralia jannakha Brisbane!
- Main menu mr-auto is fixed by ๐ Various CSS fixes Fixed
- Any new features should be put into a separate feature request issue (so bugs and new features are not mixed)
- Rather than creating multiple configuration settings (config settings for each region - as regions can change within sub-themes), it's preferable to create sub-theme and customise CSS as required
- Please run PHPCS before creating patches to keep coding standards - Status changed to Active
over 1 year ago 9:30pm 7 March 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
The elements around Search still look funny, so the problem isn't really fixed ... Perhaps we can re-open the issue, and find a solution?
- ๐ต๐ฑPoland prauat Wroclaw
@jannakha no it's not adding configurable classes should be preferred solution instead of adding more and more CSS which is then removed in various fixes. Moreover you're sacrificing the ease of use for normal user because when making subtheme advanced users can change regions?
What about settings that are not used anywhere but still display on settings page?
https://git.drupalcode.org/project/bootstrap5/-/blob/1.1.x/src/SettingsM...$form['body_details']['b5_top_container_config'] = [ '#type' => 'textarea', '#title' => t('Website container type configuration'), '#default_value' => theme_get_setting('b5_top_container_config'), '#description' => t("Format: <classes|label> on each line, e.g. <br><pre>container|fixed<br />container-fluid m-0 p-0|fluid</pre>"), ];
Correct me if I'm wrong but what is the purpose of this? As I haven't found it anywhere in the code beside SettingsManager.
At last for customize CSS I though that bootstrap is used to limit bothering with CSS to minimum and reuse prepared CSS.
Please forgive me I've forgot about phpcs because being in rush to deploy website.
@ressa Yes.
- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- @ravi-kant opened merge request.
- Status changed to Needs review
over 1 year ago 5:53am 5 July 2023 - Assigned to Jay Jangid
- ๐ฎ๐ณIndia Jay Jangid
I have reviewed patch #2 and implemented the merge request !41 provided by @ravi kant.
The patch & MR! has been implemented successfully.
Result:- Above issue resolved.
I am attaching my screenshot for your reference. Please review.
And Thank You. - Issue was unassigned.
- ๐ฎ๐ณIndia snehal-chibde
Hello, the MR gets applied successfully, patch #2 fails.
Added screenshots for reference. Hi
I'm new to Drupal (one week) and I want to use this theme. I installed both version with composer and the problem persists. I don't know how to merge or apply the patch. Is ti possible to explaim me please?
Thanks