- First commit to issue fork.
- 🇮🇳India lokeshsahu Delhi
I have created a patch to address the above issue. I am attaching a screenshot for reference, showing the state before and after applying the patch.
- Status changed to Needs review
over 1 year ago 12:57pm 13 June 2023 - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 5:58am 14 June 2023 @lokeshsahu , I verified the #3 patch and the patch is working but the only issue I can see when we are closing the menu it's showing an old menu style.
Added screenshot for reference.- Status changed to Needs review
9 months ago 11:37am 1 April 2024 Hello there,
First of all the issue summary is not very much clear, I guess we are talking about the main menu only in this regard. If so, I think this is a duplicate issue, Issue #3314868 already exist for the same.
https://www.drupal.org/project/showcase_lite/issues/3314868 🐛 No mobile menu displayed Needs reviewThe patch provided on this ticket seems to be targeting menu class generally which will affect all the menu including but not limited to only main-navigation menu. Also I've checked that the issue still persist on the latest version of the theme which is compatible with D10. So I've addressed the issue on that ticket and raised an MR by incorporating the concepts of Drupal Behaviour and Once function. Please have a look:
https://git.drupalcode.org/project/showcase_lite/-/merge_requests/10The issue is resolved now and incorporated a hamburger menu with a panel slider for the main menu on tablet and mobile devices.
This is how it looks now on responsive screens
Hi , reviewed the MR 10, Applied cleanly and also the menu looks fine. Might look better if the top white space is reduced.
Hello, @bindu r,
The hamburger menu will open up as a panel and the actual menu items are vertically center aligned with respect to the panel, so if we reduce the space from the top, it'll look asymmetrical.- Status changed to Needs work
8 months ago 6:42am 22 April 2024