- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
#2: That's great news!
Now that the number of remaining core alpha experimental blockers for Package Manager has fewer than 10 issues remaining: time to really get this going! π
Attached patch is the result of doing:
composer require symfony/config ^6.2
β¦ and it turns out that
symfony/config
depends onsymfony/filesystem
, so that's brought in as a dependency too. - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Aha!
ComposerIntegrationTest
is failing and points to https://www.drupal.org/about/core/policies/core-dependency-policies/mana... β , which is the documentation I spent 20 minutes searching for but not finding π The last submitted patch, 3: symfony-config-3326246-3.patch, failed testing. View results β
- πΊπΈUnited States effulgentsia
Updated the issue summary to be more explicit about why Package Manager needs symfony/config.
- π¬π§United Kingdom longwave UK
Would π Support resource key in services.yml Active solve the issue in PackageManagerServiceProvider without needing
symfony/config
? (assuming that that issue does not needsymfony/config
itself...)Also, it is not already a dev dependency (but
symfony/filesystem
is) - π«π·France andypost
One more reason to add it is β¨ Use native Symfony YamlLoader + Config Needs work because except addition it also starts using it
- πΊπΈUnited States effulgentsia
Re #7, yes I think it would, but I don't see why we'd want to write our own custom code for supporting a 'resource' key vs. using
symfony/config
. Re-reading #1632930: Add Symfony/Component/Config despite Symfony potentially releasing BC-breaking updates after 2.3. β , I think we rejected using symfony/config at that time, because:- In Symfony version 2, it was in the list of components that could still undergo breaking changes within a major version. I believe that hasn't been the case anymore in a long time now, and that all Symfony components respect semver now.
- There were performance concerns, but I don't know if there still are with Symfony 6. We might need to profile/benchmark it to see how much, if anything, it would add to the time it takes to rebuild the container.
- There wasn't a clearly compelling use-case (for Symfony v2 and Drupal 8.0, it wouldn't have added enough value to either our container building or our routing), but now we have one.
- πΊπΈUnited States effulgentsia
Adding π Support resource key in services.yml Active as a related issue per #7/#9.
- πΊπΈUnited States effulgentsia
Adding the need to profile/benchmark as a remaining task.
- πΊπΈUnited States effulgentsia
Meanwhile, I opened π Remove dependency on symfony/config Fixed .
- πΊπΈUnited States phenaproxima Massachusetts
So I was able to implement π Remove dependency on symfony/config Fixed without much difficulty at all. This means Package Manager no longer needs symfony/config. IMHO we should close this issue.
- Status changed to Closed: duplicate
over 1 year ago 5:39am 1 March 2023 - πΊπΈUnited States effulgentsia
Closing this as a duplicate of β¨ Use native Symfony YamlLoader + Config Needs work . I think that issue is still worth doing if whatever the remaining challenges are there can be resolved.