- Issue created by @effulgentsia
- πΊπΈUnited States phenaproxima Massachusetts
It's worth a shot. If it can be done without the use of symfony/config, I'm all in favor of dropping the dependency and closing the core issue.
- Assigned to phenaproxima
- πΊπΈUnited States phenaproxima Massachusetts
I'll dig into this for a day and see what I can do. If we can pull it off, then that basically nullifies a blocking core issue, and that's certainly worth something.
- @phenaproxima opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:26pm 28 February 2023 - πΊπΈUnited States phenaproxima Massachusetts
OK, took some real tweaking around with iterators, but I think this should do the trick.
- πΊπΈUnited States phenaproxima Massachusetts
Crediting @effulgentsia for this idea.
- Assigned to phenaproxima
- Status changed to Needs work
almost 2 years ago 8:25am 1 March 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Reviewed. IMHO this is missing a comment to ensure we remove the new logic/complexity whenever Drupal core does adopt
symfony/config
, which seems likely to happen at some point.This does avoid the dependency on
symfony/config
, but confirms the observation I posted at #3321933-11: Remove dependency on symfony/finder β which was the reason for opening π Add symfony/config to core's dependencies for package_manager Closed: duplicate :β I don't see how we can avoid using
symfony/config
if we don't want to make\Drupal\package_manager\PackageManagerServiceProvider::register()
a lot more complicated.Once a
@todo
has been added to document that this non-trivial complexity can be removed altogether if we adopt a widely used Symfony package that will remove the need for lots of contrib modules to do similar things to make autowiring work as expected in Drupal (see #3111008-2: Use native Symfony YamlLoader + Config β ), I will RTBC. - Assigned to wim leers
- Status changed to Needs review
almost 2 years ago 1:16pm 1 March 2023 - πΊπΈUnited States phenaproxima Massachusetts
Applied your suggested comment and returning to you for review, Wim.
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 1:22pm 1 March 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Thanks for that context, @phenaproxima! :D I bet it was @gabesullice who knew about static anonymous functions π€―, not me! π
-
phenaproxima β
committed d5b0279c on 3.0.x
Issue #3345039 by phenaproxima, Wim Leers, effulgentsia: Remove...
-
phenaproxima β
committed d5b0279c on 3.0.x
- Status changed to Fixed
almost 2 years ago 1:42pm 1 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.