Skip links hidden by Admin Toolbar

Created on 8 December 2022, over 1 year ago
Updated 17 October 2023, 9 months ago

Problem/Motivation

When tabbing into a page, each skip link is visible when it has focus. However, if the user is logged-in, these are hidden under the Admin Toolbar.

Steps to reproduce

Hit tab on a newly-loaded page to focus a skip link. Note that it can be seen. Login and repeat. It cannot be seen.

Proposed resolution

Display it below the Admin Toolbar.

πŸ› Bug report
Status

Fixed

Version

4.4

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡¦Canada optasy

    I did see that issue myself on v4.5 and v5.0, I have a patch for the wxt_bootstrap theme that fixes this (a small css change), we should probably create this issue in the wxt_bootstrap project as well.

  • Status changed to Needs review 9 months ago
  • Issue was unassigned.
  • Status changed to RTBC 9 months ago
  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    Looks good ! Nice work

  • Status changed to Needs review 9 months ago
  • πŸ‡¨πŸ‡¦Canada smulvih2 Canada 🍁

    The patch adds two CSS rules to _wxt.scss, but a bunch of additional changes are being made to style.css. Is this just a result of compiling the CSS (css and scss were out of sync) or were the additional changes to CSS made manually?

  • πŸ‡¨πŸ‡¦Canada optasy

    Hi @smulvih2 this is the result of compiling the scss files, should I include these only? Open to any suggestions.

  • Status changed to RTBC 9 months ago
  • πŸ‡¨πŸ‡¦Canada smulvih2 Canada 🍁

    @optasy thanks for the info! Actually now that I look at it in more detail the extra changes to CSS are just indentation fixes so all good. Also tested your patch and it fixes the issue when logged in, while continuing to work as normal for anonymous users. Thanks!

  • Status changed to Fixed 9 months ago
  • πŸ‡¨πŸ‡¦Canada sylus

    This looks great and thanks you so much for fixing this issue :)

    Committed and attributed :D

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024