Deprecate calling \Drupal\menu_link_content\Form\MenuLinkContentForm::_construct() with the $language_manager argument

Moving to NW for the open thread.

Sadly we seem not ready for these kind of changes within a time-frame that's less than one year.

So let's stick with the MR and the official ways.

I think now the reference for this type of dances should be 📌 Deprecate calling Drupal\block\Plugin\migrate\process\BlockTheme::_construct() with the $migration argument Fixed . In particular, adding typehinting to the class properties would ease the check that each property gets the expected type.

I fully agree with @mondrake, but sadly this isn't
The format to use here is not on the deprecation policy page..

No matter how much I would like to use the new format, I'm a bit tired of doing do and then having to change everything back to the official way.

So I've gone the official wsy to begin with now.
Let's hope for some official code style changes soon.

But that HAS changed since #9, hasn't it? https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

And 📌 Deprecate calling Drupal\block\Plugin\migrate\process\BlockTheme::_construct() with the $migration argument Fixed WAS committed.

Anyway, let's RTBC this, and see committers' feedback.

AFAICT I (tried to) applied the new format. Although the example with only 3 arguments and deprecating the 2nd is a bit sparse for our 6, deprecate 3rd real life situation.

3 points. The first one is a do-do imho.

Thanks @mondrake, should have figured that out myself.

Few nits in inline comments.

Change looks good to me.
All threads resolved.
Lets see if this can make it for 10.1

I bet it needs DeprecatedServicePropertyTrait to be added for removed service

Thanks @andypost, never knew about the existence of DeprecatedServicePropertyTrait
#TIL

But I don't think it's needed here, since the $language_manager argument (interestingly) never was a property on the MenuLinkContentForm class?

As I see there's few contrib modules extending the class, so would be great to provide BC
ref http://codcontrib.hank.vps-private.net/search?text=MenuLinkContentForm&f...

Added DeprecatedServicePropertyTrait

Added suggestion as expected property is languageManager but service name language_manager

Applied suggestion, closed all open threads.

Thank you!

Based MR on 11.x

Looks good. Committed/pushed to 11.x, thanks! I updated the deprecation message on commit.

Spokje → closed merge request !3066

Automatically closed - issue fixed for 2 weeks with no activity.

Published change record.